Bug 101392 – [EFL] Simplify the build system

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Laszlo Gombos]

Remove unused cmake variables, refactor build flags.

[Laszlo Gombos]

Created attachment 172648 [details]
1st try

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 172648 [details]
1st try

Looks good, I guess. These things are not enabled by default so they are not really tested by the EWS, but if you guys who are working on it say it's OK it's probably fine :-)

[Yael]

Comment on attachment 172648 [details]
1st try

View in context: https://bugs.webkit.org/attachment.cgi?id=172648&action=review

> Source/cmake/OptionsEfl.cmake:178
> -  SET(WTF_USE_ACCELERATED_COMPOSITING 1)
>    ADD_DEFINITIONS(-DWTF_USE_ACCELERATED_COMPOSITING=1)

Is this still needed after WTF_USE_ACCELERATED_COMPOSITING was moved to platform.h ?

> Source/cmake/OptionsEfl.cmake:180
> -  SET(WTF_USE_COORDINATED_GRAPHICS 1)
>    ADD_DEFINITIONS(-DWTF_USE_COORDINATED_GRAPHICS=1)

ditto

[WebKit Review Bot]

Comment on attachment 172648 [details]
1st try

Clearing flags on attachment: 172648

Committed r133678: <http://trac.webkit.org/changeset/133678>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Laszlo Gombos]

(In reply to comment #3)
> (From update of attachment 172648 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=172648&action=review
> 
> > Source/cmake/OptionsEfl.cmake:178
> > -  SET(WTF_USE_ACCELERATED_COMPOSITING 1)
> >    ADD_DEFINITIONS(-DWTF_USE_ACCELERATED_COMPOSITING=1)
> 
> Is this still needed after WTF_USE_ACCELERATED_COMPOSITING was moved to platform.h ?

At the moment WTF_USE_ACCELERATED_COMPOSITING is only enabled in OptionsEfl.cmake for EFL. 

I agree in that once we enable WTF_USE_ACCELERATED_COMPOSITING by default for EFL, it is best to do it in Platform.h and not in OptionsEfl.cmake. 

 /* Accelerated compositing */
-#if PLATFORM(MAC) || PLATFORM(IOS) || PLATFORM(QT) || (PLATFORM(WIN) && !OS(WINCE) && !PLATFORM(WIN_CAIRO))
+#if PLATFORM(MAC) || PLATFORM(IOS) || PLATFORM(QT) || PLATFORM(EFL) || (PLATFORM(WIN) && !OS(WINCE) && !PLATFORM(WIN_CAIRO))

Until this change is not made, we still need the above line in OptionsEfl.cmake.

[Yael]

(In reply to comment #6)
> (In reply to comment #3)
> > (From update of attachment 172648 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=172648&action=review
> > 
> > > Source/cmake/OptionsEfl.cmake:178
> > > -  SET(WTF_USE_ACCELERATED_COMPOSITING 1)
> > >    ADD_DEFINITIONS(-DWTF_USE_ACCELERATED_COMPOSITING=1)
> > 
> > Is this still needed after WTF_USE_ACCELERATED_COMPOSITING was moved to platform.h ?
> 
> At the moment WTF_USE_ACCELERATED_COMPOSITING is only enabled in OptionsEfl.cmake for EFL. 
> 
> I agree in that once we enable WTF_USE_ACCELERATED_COMPOSITING by default for EFL, it is best to do it in Platform.h and not in OptionsEfl.cmake. 
> 
>  /* Accelerated compositing */
> -#if PLATFORM(MAC) || PLATFORM(IOS) || PLATFORM(QT) || (PLATFORM(WIN) && !OS(WINCE) && !PLATFORM(WIN_CAIRO))
> +#if PLATFORM(MAC) || PLATFORM(IOS) || PLATFORM(QT) || PLATFORM(EFL) || (PLATFORM(WIN) && !OS(WINCE) && !PLATFORM(WIN_CAIRO))
> 
> Until this change is not made, we still need the above line in OptionsEfl.cmake.

My bad. I thought your other patch changed that .