Bug 101386 - [BlackBerry] Pushing window.external.* events to webplatform
Summary: [BlackBerry] Pushing window.external.* events to webplatform
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-06 13:14 PST by otcheung
Modified: 2012-11-06 14:00 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.40 KB, patch)
2012-11-06 13:19 PST, otcheung 		no flags Details | Formatted Diff | Diff
Patch (3.39 KB, patch)
2012-11-06 13:27 PST, otcheung 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description otcheung 2012-11-06 13:14:18 PST 
The stubs for window.external are in place. Add event calls so we can handle the event on the browser chrome.
Comment 1 otcheung 2012-11-06 13:19:49 PST 
Created attachment 172636 [details]
Patch
Comment 2 Rob Buis 2012-11-06 13:25:47 PST 
Comment on attachment 172636 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172636&action=review

Small fixies to do.

> Source/WebKit/blackberry/ChangeLog:8
> +        Adding calls to trigger window.external events so we could handle them on the

we could -> we can. Yes we can!

> Source/WebKit/blackberry/Api/WebPageClient.h:266
> +    virtual int  isSearchProviderInstalled(const Platform::String& newURL) = 0;

newURL can be left off here.
Comment 3 otcheung 2012-11-06 13:27:24 PST 
Created attachment 172638 [details]
Patch
Comment 4 Rob Buis 2012-11-06 13:28:21 PST 
Comment on attachment 172638 [details]
Patch

LGTM.
Comment 5 WebKit Review Bot 2012-11-06 14:00:50 PST 
Comment on attachment 172638 [details]
Patch

Clearing flags on attachment: 172638

Committed r133667: <http://trac.webkit.org/changeset/133667>
Comment 6 WebKit Review Bot 2012-11-06 14:00:54 PST 
All reviewed patches have been landed.  Closing bug.