Bug 101379 - Indentation of JSCell.h is wrong
Summary: Indentation of JSCell.h is wrong
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-06 11:29 PST by Filip Pizlo
Modified: 2012-11-06 13:14 PST (History)
5 users (show)

See Also:

Attachments
the patch (21.82 KB, patch)
2012-11-06 12:27 PST, Filip Pizlo 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-11-06 11:29:29 PST 
patch forthcoming
Comment 1 Filip Pizlo 2012-11-06 12:27:31 PST 
Created attachment 172630 [details]
the patch
Comment 2 WebKit Review Bot 2012-11-06 12:30:47 PST 
Attachment 172630 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/runtime/JSCell.h:91:  Use 0 or null instead of NULL (even in *comments*).  [readability/null] [4]
Source/JavaScriptCore/runtime/JSCell.h:92:  Use 0 or null instead of NULL (even in *comments*).  [readability/null] [4]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexey Proskuryakov 2012-11-06 12:34:45 PST 
Comment on attachment 172630 [details]
the patch

rs=me.

Changes like this can be just rubber-stamped on IRC, without going through Bugzilla.
Comment 4 Filip Pizlo 2012-11-06 13:14:02 PST 
Landed in http://trac.webkit.org/changeset/133661