Bug 101376 – Enable REQUEST_AUTOCOMPLETE for chromium port

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Dan Beam]

This bug is to enable the feature flag REQUEST_AUTOCOMPLETE for the chromium port of WebKit and adjust the test expectations for this platform.

[Dan Beam]

Created attachment 172655 [details]
Patch

[Adam Barth]

Comment on attachment 172655 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172655&action=review

> Source/WebKit/chromium/ChangeLog:9
> +        This patch enables the feature flag REQUEST_AUTOCOMPLETE in WebKit/chromium only to allow web authors to start to use
> +        HTMLFormElement#requestAutocomplete as the chrome-side work progresses further.

Is there a runtime switch hide this feature from the web while it is in development?

[Adam Barth]

Comment on attachment 172655 [details]
Patch

Dan is going to add a runtime switch to control this function via V8EnabledAtRuntime.

[Dan Beam]

Created attachment 172691 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Dan Beam]

Comment on attachment 172655 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172655&action=review

>> Source/WebKit/chromium/ChangeLog:9
>> +        HTMLFormElement#requestAutocomplete as the chrome-side work progresses further.
> 
> Is there a runtime switch hide this feature from the web while it is in development?

There will be a runtime switch that must be enabled in Chrome to use this feature, yes.

[Adam Barth]

Comment on attachment 172691 [details]
Patch

Looks great.

[WebKit Review Bot]

Comment on attachment 172691 [details]
Patch

Rejecting attachment 172691 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
webkit-commit-queue/Source/WebKit/chromium/webkit --revision 166220 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
51>At revision 166220.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/14759190

[Adam Barth]

Comment on attachment 172691 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172691&action=review

> Source/WebCore/ChangeLog:10
> +        No new tests (OOPS!).

This line is causing the commit-queue to be sad.  We should either list the tests that you're modifying or remove it.

[Dan Beam]

Created attachment 172708 [details]
Patch

[Dan Beam]

Comment on attachment 172691 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172691&action=review

>> Source/WebCore/ChangeLog:10
>> +        No new tests (OOPS!).
> 
> This line is causing the commit-queue to be sad.  We should either list the tests that you're modifying or remove it.

Removed.

[WebKit Review Bot]

Comment on attachment 172708 [details]
Patch

Clearing flags on attachment: 172708

Committed r133720: <http://trac.webkit.org/changeset/133720>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.