Bug 101375 - Some cookie code cleanup
Summary: Some cookie code cleanup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-06 10:59 PST by Alexey Proskuryakov
Modified: 2012-11-06 13:37 PST (History)
3 users (show)

See Also:

Attachments
proposed patch (9.31 KB, patch)
2012-11-06 11:08 PST, Alexey Proskuryakov 		mitz: review+
Details | Formatted Diff | Diff
patch for landing (9.31 KB, patch)
2012-11-06 12:37 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2012-11-06 10:59:31 PST 
Doing it in small steps.
Comment 1 Alexey Proskuryakov 2012-11-06 11:08:24 PST 
Created attachment 172621 [details]
proposed patch
Comment 2 mitz 2012-11-06 11:15:06 PST 
Comment on attachment 172621 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172621&action=review

> Source/WebCore/ChangeLog:13
> +        (WebCore): Removed special code for isHTTPOnly, it's present Foundation in all

Typo: “present Foundation”

> Source/WebCore/ChangeLog:19
> +        Set-Cookie header, document.cookie can only be used to saet one cookie at a time.

Typo: “saet”

> Source/WebCore/platform/CookieJar.h:40
> +// These two methods implement document.cookie API, with special rules for HttpOnly cookies.

“(member) functions” rather than “methods”?
Comment 3 Alexey Proskuryakov 2012-11-06 12:37:24 PST 
Created attachment 172631 [details]
patch for landing
Comment 4 WebKit Review Bot 2012-11-06 13:25:04 PST 
Comment on attachment 172631 [details]
patch for landing

Clearing flags on attachment: 172631

Committed r133664: <http://trac.webkit.org/changeset/133664>