Bug 101367 - check-webkit-style false report about asm() code in DFGOperations.cpp.
Summary: check-webkit-style false report about asm() code in DFGOperations.cpp.
Status: UNCONFIRMED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-06 10:09 PST by Balazs Kilvady
Modified: 2017-07-18 08:29 PDT (History)
9 users (show)

See Also:

Attachments
patch (2.63 KB, patch)
2012-11-08 10:09 PST, Balazs Kilvady 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kilvady 2012-11-06 10:09:49 PST 
As I didn't find coding style rules to asm(…) blocks just followed the style/indention of existing asm(… ) blocks but received:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/dfg/DFGOperations.cpp:1569:  The parameter name """" adds no information, so it should be removed.  [readability/parameter_name] [5]

for:

asm(
".text" "\n"
".globl " SYMBOL_STRING(getHostCallReturnValue) "\n"
HIDE_SYMBOL(getHostCallReturnValue) "\n"
SYMBOL_STRING(getHostCallReturnValue) ":" "\n"
    LOAD_FUNCTION_TO_T9(getHostCallReturnValueWithExecState)
    "lw $s0, -40($s0)" "\n"
    "move $a0, $s0" "\n"
    "b " LOCAL_REFERENCE(getHostCallReturnValueWithExecState) "\n"
);

Where line 1569 is the closing );
Comment 1 Balazs Kilvady 2012-11-08 10:09:52 PST 
Created attachment 173060 [details]
patch

With this patch "asm(" "asm (" "__asm(" and "__asm (" blocks accepted at style checking.
Comment 2 Simon Hausmann 2013-01-31 23:09:18 PST 
Comment on attachment 173060 [details]
patch

Would it make sense perhaps to also add a unit test for this in cpp_unittest.py?
Comment 3 Anders Carlsson 2014-02-05 11:07:47 PST 
Comment on attachment 173060 [details]
patch

Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.