Bug 101364 - [CSS Regions] Fix failing tests on Mac after sub-pixel layout was enabled
Summary: [CSS Regions] Fix failing tests on Mac after sub-pixel layout was enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andrei Bucur
URL:
Keywords:
Depends on:
Blocks: 57312 101220
  Show dependency treegraph
 
Reported: 2012-11-06 09:39 PST by Andrei Bucur
Modified: 2012-11-06 11:19 PST (History)
3 users (show)

See Also:


Attachments
Patch (3.33 KB, patch)
2012-11-06 10:30 PST, Andrei Bucur
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Bucur 2012-11-06 09:39:19 PST
Three tests started failing after sub-pixel layout started failing after sub-pixel layout was enabled on Mac:
LayoutTests/fast/regions/float-pushed-width-change.html
LayoutTests/fast/regions/floats-basic-in-variable-width-regions.html
LayoutTests/fast/regions/render-region-renderer.html

Fix the tests or the issues in code that caused the failings.
Comment 1 Simon Fraser (smfr) 2012-11-06 10:28:23 PST
These are reference tests, which suggests that the references are not really doing layout the same way as the actual test.

I'm curious about how other platforms that enable SUBPIXEL_LAYOUT handle this.
Comment 2 Andrei Bucur 2012-11-06 10:30:32 PST
Created attachment 172612 [details]
Patch
Comment 3 WebKit Review Bot 2012-11-06 11:19:02 PST
Comment on attachment 172612 [details]
Patch

Clearing flags on attachment: 172612

Committed r133648: <http://trac.webkit.org/changeset/133648>
Comment 4 WebKit Review Bot 2012-11-06 11:19:05 PST
All reviewed patches have been landed.  Closing bug.