Bug 101363 - Web Inspector: Infinite loop in DataGrid::autoSizeColumn
Summary: Web Inspector: Infinite loop in DataGrid::autoSizeColumn
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-06 09:24 PST by Vsevolod Vlasov
Modified: 2012-11-08 03:49 PST (History)
10 users (show)

See Also:

Attachments
Patch (1.98 KB, patch)
2012-11-06 09:25 PST, Vsevolod Vlasov 		no flags Details | Formatted Diff | Diff
Patch (9.58 KB, patch)
2012-11-07 06:47 PST, Vsevolod Vlasov 		no flags Details | Formatted Diff | Diff
Patch (9.69 KB, patch)
2012-11-07 06:55 PST, Vsevolod Vlasov 		no flags Details | Formatted Diff | Diff
Patch (9.69 KB, patch)
2012-11-07 08:36 PST, Vsevolod Vlasov 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-11-06 09:24:19 PST 
Patch to follow.
Comment 1 Vsevolod Vlasov 2012-11-06 09:25:12 PST 
Created attachment 172603 [details]
Patch
Comment 2 Pavel Feldman 2012-11-07 05:48:13 PST 
Comment on attachment 172603 [details]
Patch

A test?
Comment 4 Vsevolod Vlasov 2012-11-07 06:47:53 PST 
Created attachment 172787 [details]
Patch
Comment 5 Vsevolod Vlasov 2012-11-07 06:55:59 PST 
Created attachment 172789 [details]
Patch
Comment 6 Build Bot 2012-11-07 08:11:08 PST 
Comment on attachment 172789 [details]
Patch

Attachment 172789 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14757413

New failing tests:
inspector/storage-panel-dom-storage.html
inspector/console/command-line-api-inspect.html
inspector/storage-panel-dom-storage-update.html
Comment 7 WebKit Review Bot 2012-11-07 08:15:33 PST 
Comment on attachment 172789 [details]
Patch

Attachment 172789 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14759391

New failing tests:
inspector/storage-panel-dom-storage.html
inspector/console/command-line-api-inspect.html
inspector/storage-panel-dom-storage-update.html
Comment 8 Vsevolod Vlasov 2012-11-07 08:36:54 PST 
Created attachment 172816 [details]
Patch
Comment 9 WebKit Review Bot 2012-11-07 22:45:31 PST 
Comment on attachment 172816 [details]
Patch

Clearing flags on attachment: 172816

Committed r133851: <http://trac.webkit.org/changeset/133851>
Comment 10 WebKit Review Bot 2012-11-07 22:45:34 PST 
All reviewed patches have been landed.  Closing bug.
Comment 11 eustas.bug 2012-11-08 01:58:23 PST 
Comment on attachment 172816 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172816&action=review

> Source/WebCore/inspector/front-end/DataGrid.js:439
> +     * @param {Array<number>} widths

You've missed "." between "Array" and "<number>"
Comment 12 Vsevolod Vlasov 2012-11-08 03:49:42 PST 
(In reply to comment #11)
> (From update of attachment 172816 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=172816&action=review
> 
> > Source/WebCore/inspector/front-end/DataGrid.js:439
> > +     * @param {Array<number>} widths
> 
> You've missed "." between "Array" and "<number>"

Thank you, fixed.