Bug 101360 - [EFL][WK2] Declare all smart callbacks in EwkViewCallbacks.h
Summary: [EFL][WK2] Declare all smart callbacks in EwkViewCallbacks.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-06 09:05 PST by Chris Dumez
Modified: 2012-11-06 11:09 PST (History)
8 users (show)

See Also:

Attachments
Patch (5.87 KB, patch)
2012-11-06 09:59 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-11-06 09:05:38 PST 
Some of the EwkView callbacks are not defined in EwkViewCallbacks.h, instead the callers still use evas_object_smart_callback_call(). We should move all of them to EwkViewCallbacks.h for consistency and for better argument type checking.
Comment 1 Chris Dumez 2012-11-06 09:59:20 PST 
Created attachment 172607 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-06 11:09:01 PST 
Comment on attachment 172607 [details]
Patch

Clearing flags on attachment: 172607

Committed r133643: <http://trac.webkit.org/changeset/133643>
Comment 3 WebKit Review Bot 2012-11-06 11:09:05 PST 
All reviewed patches have been landed.  Closing bug.