Bug 101358 – [WK2] Wrong scroll position when going back in history

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Yael]

When loading page A, scrolling down, then loading page B, scrolling down, and then going back in history, the scroll position is not preserved.
When we go back in history, we send the new visibleContentsRect to the web process, and that turns on the flag wasScrolledByUser. The history controller does not send the saved history scrollPosition, because this flag is set.

Looking at it further, I found out that when the load is committed, we are still using the contentsSize of the previous page. Resetting the contentsSize of the page prevents prevents this bug.

A patch is coming.

[Yael]

Created attachment 172598 [details]
Patch

[Laszlo Gombos]

[EFL] prefix should be probably removed from the bug (title + ChangeLog). 

It looks good to me.

[Yael]

(In reply to comment #2)
> [EFL] prefix should be probably removed from the bug (title + ChangeLog). 
> 
> It looks good to me.
Perhaps add [Qt] instead? This is not an issue for gtk or mac ports .

[Laszlo Gombos]

> Perhaps add [Qt] instead? This is not an issue for gtk or mac ports .

Yes, that is better.

[Kenneth Rohde Christiansen]

Comment on attachment 172598 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172598&action=review

> Source/WebKit2/ChangeLog:3
> +        [EFL][WK2] Wrong scroll position when going back in history

Remove [EFL], as this code can be used be all.

[Yael]

(In reply to comment #5)
> (From update of attachment 172598 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=172598&action=review
> 
> > Source/WebKit2/ChangeLog:3
> > +        [EFL][WK2] Wrong scroll position when going back in history
> 
> Remove [EFL], as this code can be used be all.
ok

[Yael]

Created attachment 172615 [details]
Patch for landing.

[WebKit Review Bot]

Comment on attachment 172615 [details]
Patch for landing.

Clearing flags on attachment: 172615

Committed r133659: <http://trac.webkit.org/changeset/133659>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.