[WTR] Reset EventSender before running each test.
Created attachment 172588 [details] Patch
Comment on attachment 172588 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172588&action=review > Tools/WebKitTestRunner/TestController.cpp:507 > + // Reset the EventSender for each test. > +#if PLATFORM(MAC) || PLATFORM(QT) || PLATFORM(GTK) || PLATFORM(EFL) > + m_eventSenderProxy = adoptPtr(new EventSenderProxy(this)); > +#endif I'm not 100% sure this is the best place to do it (we could make EventSendingController::makeWindowObject() send a message and act when it is received, for example), or whether calling some EventSenderProxy::resetState() makes more sense. I'm open to suggestions.
Comment on attachment 172588 [details] Patch Attachment 172588 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14728855
Created attachment 172590 [details] Add dummy destructors to the mac/gtk/qt ports
Comment on attachment 172590 [details] Add dummy destructors to the mac/gtk/qt ports Attachment 172590 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14758008
Created attachment 172595 [details] Patch
Comment on attachment 172595 [details] Patch LGTM.
Comment on attachment 172595 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172595&action=review > Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:88 > +EventSenderProxy::~EventSenderProxy() > +{ > +} Is there any port that requires a non-empty destructor? If not, you could remove them all.
(In reply to comment #8) > (From update of attachment 172595 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=172595&action=review > > > Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:88 > > +EventSenderProxy::~EventSenderProxy() > > +{ > > +} > > Is there any port that requires a non-empty destructor? If not, you could remove them all. The EFL one currently clears the list of selected touch points when ENABLE(TOUCH_EVENTS) is on, so I guess it makes sense to keep these for now.
Committed r133676: <http://trac.webkit.org/changeset/133676>
*** Bug 92231 has been marked as a duplicate of this bug. ***