Bug 101353 – [WTR] Reset EventSender before running each test.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Raphael Kubo da Costa (:rakuco)]

[WTR] Reset EventSender before running each test.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 172588 [details]
Patch

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 172588 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172588&action=review

> Tools/WebKitTestRunner/TestController.cpp:507
> +    // Reset the EventSender for each test.
> +#if PLATFORM(MAC) || PLATFORM(QT) || PLATFORM(GTK) || PLATFORM(EFL)
> +    m_eventSenderProxy = adoptPtr(new EventSenderProxy(this));
> +#endif

I'm not 100% sure this is the best place to do it (we could make EventSendingController::makeWindowObject() send a message and act when it is received, for example), or whether calling some EventSenderProxy::resetState() makes more sense. I'm open to suggestions.

[Early Warning System Bot]

Comment on attachment 172588 [details]
Patch

Attachment 172588 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14728855

[Raphael Kubo da Costa (:rakuco)]

Created attachment 172590 [details]
Add dummy destructors to the mac/gtk/qt ports

[Build Bot]

Comment on attachment 172590 [details]
Add dummy destructors to the mac/gtk/qt ports

Attachment 172590 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14758008

[Raphael Kubo da Costa (:rakuco)]

Created attachment 172595 [details]
Patch

[Rafael Brandao]

Comment on attachment 172595 [details]
Patch

LGTM.

[Simon Fraser (smfr)]

Comment on attachment 172595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172595&action=review

> Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:88
> +EventSenderProxy::~EventSenderProxy()
> +{
> +}

Is there any port that requires a non-empty destructor? If not, you could remove them all.

[Raphael Kubo da Costa (:rakuco)]

(In reply to comment #8)
> (From update of attachment 172595 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=172595&action=review
> 
> > Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:88
> > +EventSenderProxy::~EventSenderProxy()
> > +{
> > +}
> 
> Is there any port that requires a non-empty destructor? If not, you could remove them all.

The EFL one currently clears the list of selected touch points when ENABLE(TOUCH_EVENTS) is on, so I guess it makes sense to keep these for now.

[Raphael Kubo da Costa (:rakuco)]

Committed r133676: <http://trac.webkit.org/changeset/133676>

[Csaba Osztrogonác]

*** Bug 92231 has been marked as a duplicate of this bug. ***