Bug 101334 – Web Inspector: Timeline: 'undefined' javascript filenames.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

Steps to reproduce:
1. Record a trace while navigating in google code search (eg. http://code.google.com/p/chromium/source/search?q=file%3Aeventhandler.cpp)
2. Try to drill into why some events are taking a long time.

Result:
Source locations look like 'undefined:NNNN' and so clicking on them doesn't work.

Original report:
http://code.google.com/p/chromium/issues/detail?id=159413

V8 patch:
https://codereview.appspot.com/6811090/

Fixed in V8.
Adding test.

Created attachment 174082 [details]
Patch

[Pavel Feldman]

Comment on attachment 174082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174082&action=review

> LayoutTests/inspector/timeline/timeline-timer-fired-from-eval-call-site.html:24
> +        InspectorTest.evaluateInPage("performActions()");

You should use named function start here as you have finish below.

> LayoutTests/inspector/timeline/timeline-timer-fired-from-eval-call-site.html:30
> +        function formatter(record) {

{ on the next line

> LayoutTests/inspector/timeline/timeline-timer-fired-from-eval-call-site.html:42
> +    setTimeout(performActions, 3000);

Never use setTimeout in tests. Do this from within startTimeline callback

[Pavel Feldman]

Comment on attachment 174082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174082&action=review

> LayoutTests/inspector/timeline/timeline-timer-fired-from-eval-call-site.html:41
> +if (!window.testRunner)

Sorry, I take it back - this is debugging!

Comment on attachment 174082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174082&action=review

>> LayoutTests/inspector/timeline/timeline-timer-fired-from-eval-call-site.html:24
>> +        InspectorTest.evaluateInPage("performActions()");
> 
> You should use named function start here as you have finish below.

Done

>> LayoutTests/inspector/timeline/timeline-timer-fired-from-eval-call-site.html:30
>> +        function formatter(record) {
> 
> { on the next line

Fixed

Created attachment 174096 [details]
Patch

[WebKit Review Bot]

Comment on attachment 174096 [details]
Patch

Clearing flags on attachment: 174096

Committed r134573: <http://trac.webkit.org/changeset/134573>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

The new test fails on Mac and Qt:

--- /Volumes/Data/slave/lion-release-tests-wk1/build/layout-test-results/inspector/timeline/timeline-timer-fired-from-eval-call-site-expected.txt
+++ /Volumes/Data/slave/lion-release-tests-wk1/build/layout-test-results/inspector/timeline/timeline-timer-fired-from-eval-call-site-actual.txt
@@ -1,5 +1,5 @@
 Tests the Timeline API instrumentation of a TimerFired events inside evaluated scripts.
 
-TimerFire fromEval.js:2
-TimerFire fromEval.js:1
+TimerFire :2
+TimerFire :1

[Pavel Feldman]

We need to land Qt baselines as default and the existing ones should go to under platform/chromium.

[Pavel Feldman]

Landed r134589 with that.