RESOLVED FIXED 101329
[Chromium-win] Refactor date/time format conversion code in LocaleWin
https://bugs.webkit.org/show_bug.cgi?id=101329
Summary [Chromium-win] Refactor date/time format conversion code in LocaleWin
Kent Tamura
Reported 2012-11-06 02:49:45 PST
[Chromium-win] Refactor date/time format parsing code in LocaleWin
Attachments
Patch (13.86 KB, patch)
2012-11-06 03:02 PST, Kent Tamura
no flags
Kent Tamura
Comment 1 2012-11-06 03:02:15 PST
Kentaro Hara
Comment 2 2012-11-06 03:48:38 PST
Comment on attachment 172535 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172535&action=review > Source/WebCore/platform/text/win/LocaleWin.cpp:242 > + else > + converted.append("EEEE"); 'ddddd' is converted to 'EEEE'. Is it expected? > Source/WebCore/platform/text/win/LocaleWin.cpp:251 > + } else if (ch == 't') > + converted.append('a'); 't' and 'tt' are converted to 'a', which looks ok. 'ttt' is also converted to 'a', is it expected?
Kent Tamura
Comment 3 2012-11-06 05:00:14 PST
Comment on attachment 172535 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172535&action=review >> Source/WebCore/platform/text/win/LocaleWin.cpp:242 >> + converted.append("EEEE"); > > 'ddddd' is converted to 'EEEE'. Is it expected? Yes. ddddd is invalid according to MSDN, and users can't set arbitrary format in Control Panel. ddddd should not appear unless OS is corrupted, and any behavior would be ok here. >> Source/WebCore/platform/text/win/LocaleWin.cpp:251 >> + converted.append('a'); > > 't' and 'tt' are converted to 'a', which looks ok. 'ttt' is also converted to 'a', is it expected? Ditto.
Kentaro Hara
Comment 4 2012-11-06 05:00:57 PST
Comment on attachment 172535 [details] Patch Makes sense. Thanks for the clarification.
WebKit Review Bot
Comment 5 2012-11-06 19:34:06 PST
Comment on attachment 172535 [details] Patch Clearing flags on attachment: 172535 Committed r133712: <http://trac.webkit.org/changeset/133712>
WebKit Review Bot
Comment 6 2012-11-06 19:34:10 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 7 2012-11-07 06:04:22 PST
Re-opened since this is blocked by bug 101461
Kent Tamura
Comment 8 2012-11-07 17:20:45 PST
(In reply to comment #7) > Re-opened since this is blocked by bug 101461 Oh, XP-only failures. I found my change unveiled a bug in the XP/Vista-only path of LocaleWin::shortTimeFormat, which converts a format twice.
Kent Tamura
Comment 9 2012-11-07 20:12:46 PST
Note You need to log in before you can comment on or make changes to this bug.