Bug 101323 - [EFL] Bump Harfbuzz to allow fixing bug 101009 on EFL
Summary: [EFL] Bump Harfbuzz to allow fixing bug 101009 on EFL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dominik Röttsches (drott)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-06 01:33 PST by Dominik Röttsches (drott)
Modified: 2012-11-15 09:00 PST (History)
7 users (show)

See Also:

Attachments
Bumping version, removing ifdef. (4.49 KB, patch)
2012-11-06 06:20 PST, Dominik Röttsches (drott) 		no flags Details | Formatted Diff | Diff
Patch (6.74 KB, patch)
2012-11-07 08:13 PST, Dominik Röttsches (drott) 		no flags Details | Formatted Diff | Diff
Patch v2. Against harfbuzz 0.9.6 release. (6.24 KB, patch)
2012-11-15 05:10 PST, Dominik Röttsches (drott) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Röttsches (drott) 2012-11-06 01:33:38 PST 
Bug 101009 has a fix ifdef'ed for Chromium due to a difference in HarfBuzz versions, let's bump.
Comment 1 Dominik Röttsches (drott) 2012-11-06 04:42:33 PST 
Problematic issue with harfbuzz not finding ICU, as Martin Robinson mentions:
https://bugs.webkit.org/show_bug.cgi?id=92098#c13

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=687339
Comment 2 Dominik Röttsches (drott) 2012-11-06 04:49:36 PST 
Ubuntu Bug https://bugs.launchpad.net/ubuntu/+source/icu/+bug/1037588
Comment 3 Dominik Röttsches (drott) 2012-11-06 06:12:10 PST 
Waiting for Harfbuzz to merge the build fix proposal:
http://lists.freedesktop.org/archives/harfbuzz/2012-November/002612.html
Comment 4 Dominik Röttsches (drott) 2012-11-06 06:20:13 PST 
Created attachment 172569 [details]
Bumping version, removing ifdef.
Comment 5 Dominik Röttsches (drott) 2012-11-06 06:22:23 PST 
(In reply to comment #4)
> Created an attachment (id=172569) [details]
> Bumping version, removing ifdef.

The exact hash needs to be updated once Behdad would merge my buildfix proposal.
Comment 6 EFL EWS Bot 2012-11-06 07:56:38 PST 
Comment on attachment 172569 [details]
Bumping version, removing ifdef.

Attachment 172569 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14731763
Comment 7 Dominik Röttsches (drott) 2012-11-07 08:13:36 PST 
Created attachment 172807 [details]
Patch
Comment 8 Martin Robinson 2012-11-07 08:44:10 PST 
Wouldn't it be better just to wait for 0.9.6?
Comment 9 EFL EWS Bot 2012-11-07 08:57:41 PST 
Comment on attachment 172807 [details]
Patch

Attachment 172807 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14755511
Comment 10 Dominik Röttsches (drott) 2012-11-15 05:10:53 PST 
Created attachment 174410 [details]
Patch v2. Against harfbuzz 0.9.6 release.
Comment 11 Dominik Röttsches (drott) 2012-11-15 05:13:03 PST 
(In reply to comment #8)
> Wouldn't it be better just to wait for 0.9.6?

Unfortunately, my build fix was not important enough to be merged into 0.9.6. :-(
Comment 12 Martin Robinson 2012-11-15 08:30:18 PST 
Comment on attachment 174410 [details]
Patch v2. Against harfbuzz 0.9.6 release.

Great work. Thanks!
Comment 13 WebKit Review Bot 2012-11-15 09:00:02 PST 
Comment on attachment 174410 [details]
Patch v2. Against harfbuzz 0.9.6 release.

Clearing flags on attachment: 174410

Committed r134781: <http://trac.webkit.org/changeset/134781>
Comment 14 WebKit Review Bot 2012-11-15 09:00:07 PST 
All reviewed patches have been landed.  Closing bug.