Bug 101322 - [EFL][WK2] Make Ewk_Context Ewk_Object
Summary: [EFL][WK2] Make Ewk_Context Ewk_Object
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords:
Depends on:
Blocks: 101057
  Show dependency tree / graph
 
Reported: 2012-11-06 01:32 PST by Mikhail Pozdnyakov
Modified: 2012-11-06 04:35 PST (History)
6 users (show)

See Also:

Attachments
patch (25.37 KB, patch)
2012-11-06 02:30 PST, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2012-11-06 01:32:55 PST 
Ewk_Context should be Ewk_Object, as part of bug101057 work.
Comment 1 Mikhail Pozdnyakov 2012-11-06 02:30:35 PST 
Created attachment 172530 [details]
patch
Comment 2 Kenneth Rohde Christiansen 2012-11-06 02:41:11 PST 
Comment on attachment 172530 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172530&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_context.cpp:199
> +void EwkContext::addVisitedLink(const String& visitedURL)

Isn't this confusing now? What abut WebContextEfl ?
Comment 3 Mikhail Pozdnyakov 2012-11-06 02:55:03 PST 
(In reply to comment #2)
> (From update of attachment 172530 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=172530&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_context.cpp:199
> > +void EwkContext::addVisitedLink(const String& visitedURL)
> 
> Isn't this confusing now? What abut WebContextEfl ?

I don't mind, however how about other classes? WebURLRequsetEfl instead of present EwkUrlRequest?
Comment 4 Chris Dumez 2012-11-06 03:25:06 PST 
Comment on attachment 172530 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172530&action=review

>>> Source/WebKit2/UIProcess/API/efl/ewk_context.cpp:199
>>> +void EwkContext::addVisitedLink(const String& visitedURL)
>> 
>> Isn't this confusing now? What abut WebContextEfl ?
> 
> I don't mind, however how about other classes? WebURLRequsetEfl instead of present EwkUrlRequest?

Why is it confusing? EwkContext is a Ewk Object. Kenneth, you want to call it "WebContextEfl"? why? I think then it would become confusing because we already have a WebContextEfl.cpp file (to provide EFL-specific implementation of some WebContext methods).
Comment 5 WebKit Review Bot 2012-11-06 04:35:45 PST 
Comment on attachment 172530 [details]
patch

Clearing flags on attachment: 172530

Committed r133587: <http://trac.webkit.org/changeset/133587>
Comment 6 WebKit Review Bot 2012-11-06 04:35:50 PST 
All reviewed patches have been landed.  Closing bug.