Bug 101320 – Console not displaying all properties of an Object once native Constructor overwritten

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Yury Semikhatsky]

Original Chromium bug report: http://code.google.com/p/chromium/issues/detail?id=159408

Steps to reproduce the problem:
1. Open dev tools and declare object foo with property bar that has value 'hello,world'(used object literal to create object) 
2. log foo (bar and __proto__ properties displayed)
3. overwrite Object constructor (Object = function() {})
4. log foo again (no properties displayed)
5. log foo.bar ('hello,world' printed)

What is the expected behavior?
All the available properties of the object should still be visible as object has already been created prior to the constructor being overwritten.

What went wrong?
The console does not display the object's properties when the properties do exist. Can still log the individual values of the properties, but not the entire object.

[Yury Semikhatsky]

Created attachment 172515 [details]
Patch

[Pavel Feldman]

Comment on attachment 172515 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172515&action=review

> Source/WebCore/inspector/InjectedScriptSource.js:37
> +var Object = {}.constructor;

This could be too late, right?

[Yury Semikhatsky]

Created attachment 172516 [details]
Patch

[Yury Semikhatsky]

(In reply to comment #2)
> (From update of attachment 172515 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=172515&action=review
> 
> > Source/WebCore/inspector/InjectedScriptSource.js:37
> > +var Object = {}.constructor;
> 
> This could be too late, right?

Could you elaborate?

[WebKit Review Bot]

Comment on attachment 172516 [details]
Patch

Rejecting attachment 172516 [details] from commit-queue.

New failing tests:
inspector/console/command-line-api.html
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Full output: http://queues.webkit.org/results/14728814

[Build Bot]

Comment on attachment 172516 [details]
Patch

Attachment 172516 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14755114

New failing tests:
inspector/console/command-line-api.html

[WebKit Review Bot]

Comment on attachment 172516 [details]
Patch

Attachment 172516 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14756009

New failing tests:
inspector/console/command-line-api.html

[Yury Semikhatsky]

Committed r133727: <http://trac.webkit.org/changeset/133727>