Bug 101319 - ScriptWrappable should work for more than just Node
Summary: ScriptWrappable should work for more than just Node
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 101279
  Show dependency treegraph
 
Reported: 2012-11-06 01:07 PST by Adam Barth
Modified: 2012-11-06 10:20 PST (History)
7 users (show)

See Also:


Attachments
Patch (4.99 KB, patch)
2012-11-06 01:08 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-11-06 01:07:14 PST
ScriptWrappable should work for more than just Node
Comment 1 Adam Barth 2012-11-06 01:08:50 PST
Created attachment 172510 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-11-06 01:21:35 PST
Comment on attachment 172510 [details]
Patch

LGTM.  Mostly just moving code.  YOu may want ggaren, olliej, gavin, etc. to look before you land -- their JSC knowledge is much fresher than mine.
Comment 3 Kentaro Hara 2012-11-06 01:23:03 PST
Comment on attachment 172510 [details]
Patch

LGTM too.
Comment 4 Adam Barth 2012-11-06 07:33:55 PST
@ggaren: Would you like to take a look before I land this patch?  This is related to http://lists.webkit.org/pipermail/webkit-dev/2012-November/022737.html
Comment 5 Adam Barth 2012-11-06 09:45:50 PST
Comment on attachment 172510 [details]
Patch

This patch combined with the patch in bug 101279 is a 69% improvement for JSC in the performance of document.implementation.  I'd like to move forward with these patches.  ggaren, if you have feedback, I'm happy to address it in a followup patch.
Comment 6 WebKit Review Bot 2012-11-06 10:20:14 PST
Comment on attachment 172510 [details]
Patch

Clearing flags on attachment: 172510

Committed r133633: <http://trac.webkit.org/changeset/133633>
Comment 7 WebKit Review Bot 2012-11-06 10:20:18 PST
All reviewed patches have been landed.  Closing bug.