Bug 101316 - ShadowRoot::insertedInto is called many times without calling removedFrom when parsing <video controls>
Summary: ShadowRoot::insertedInto is called many times without calling removedFrom whe...
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Web Components Team
URL:
Keywords:
Depends on:
Blocks: 72352
  Show dependency tree / graph
 
Reported: 2012-11-06 00:28 PST by Shinya Kawanaka
Modified: 2019-10-04 22:48 PDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2012-11-06 00:28:15 PST 
I noticed this when I was working for Bug 100922. This might cause mysterious errors in future.
Comment 1 Shinya Kawanaka 2012-11-06 20:26:44 PST 
The root cause seems HTMLMediaElement creates Shadow subtree in insertedInto().
This seems a bad signal...
Comment 2 Hajime Morrita 2012-11-08 22:31:55 PST 
(In reply to comment #1)

> The root cause seems HTMLMediaElement creates Shadow subtree in insertedInto().
> This seems a bad signal...
It sounds reasonable to get rid of the shadow construction from insertedInto().
I'm not sure where is the best place though. 
It needs further investigation.
Comment 3 Dimitri Glazkov (Google) 2012-11-09 09:18:23 PST 
Yeah, this is crufty. insertedInto is a really low-level hook, and it's tempting to use it various convenient purposes. However, being a low-level hook, it's also a minefield in situations like this.
Comment 4 Ryosuke Niwa 2019-10-04 22:48:34 PDT 
configureMediaControls() is now called in HTMLMediaElement::didFinishInsertingNode() so this is no longer happening.