Bug 101314 - Indentation of JSArray.h is wrong
Summary: Indentation of JSArray.h is wrong
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-05 23:55 PST by Filip Pizlo
Modified: 2012-11-06 11:14 PST (History)
4 users (show)

See Also:

Attachments
the patch (23.53 KB, patch)
2012-11-06 00:02 PST, Filip Pizlo 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-11-05 23:55:59 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2012-11-06 00:02:09 PST 
Created attachment 172499 [details]
the patch
Comment 2 WebKit Review Bot 2012-11-06 00:27:24 PST 
Attachment 172499 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/runtime/JSArray.h:225:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexey Proskuryakov 2012-11-06 10:09:07 PST 
Comment on attachment 172499 [details]
the patch

rs=me, assuming that this was a single Cmd+[ (or equivalent).
Comment 4 Filip Pizlo 2012-11-06 11:06:58 PST 
(In reply to comment #3)
> (From update of attachment 172499 [details])
> rs=me, assuming that this was a single Cmd+[ (or equivalent).

Yup, it was.  Thanks!
Comment 5 Filip Pizlo 2012-11-06 11:11:34 PST 
Landed in http://trac.webkit.org/changeset/133645

I just realized that I wrote that it was "Reviewed by Alexey" rather than "Rubber stamped by Alexey".  I will fix the changelog in a separate commit.
Comment 6 Filip Pizlo 2012-11-06 11:14:47 PST 
Changelog fixed in http://trac.webkit.org/changeset/133646