Bug 101313 - Indentation of JSObject.h is wrong
Summary: Indentation of JSObject.h is wrong
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-05 23:53 PST by Filip Pizlo
Modified: 2012-11-06 11:19 PST (History)
4 users (show)

See Also:

Attachments
the patch (66.82 KB, patch)
2012-11-05 23:57 PST, Filip Pizlo 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-11-05 23:53:52 PST 
We don't indent inside namespaces.
Comment 1 Filip Pizlo 2012-11-05 23:57:17 PST 
Created attachment 172495 [details]
the patch
Comment 2 WebKit Review Bot 2012-11-06 00:02:43 PST 
Attachment 172495 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/runtime/JSObject.h:80:  One space before end of line comments  [whitespace/comments] [5]
Source/JavaScriptCore/runtime/JSObject.h:81:  One space before end of line comments  [whitespace/comments] [5]
Source/JavaScriptCore/runtime/JSObject.h:82:  One space before end of line comments  [whitespace/comments] [5]
Source/JavaScriptCore/runtime/JSObject.h:83:  One space before end of line comments  [whitespace/comments] [5]
Source/JavaScriptCore/runtime/JSObject.h:84:  One space before end of line comments  [whitespace/comments] [5]
Source/JavaScriptCore/runtime/JSObject.h:542:  The parameter name "exec" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/runtime/JSObject.h:777:  The parameter name "exec" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 7 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexey Proskuryakov 2012-11-06 10:08:41 PST 
Comment on attachment 172495 [details]
the patch

rs=me, assuming that this was a single Cmd+[ (or equivalent).
Comment 4 Filip Pizlo 2012-11-06 11:15:30 PST 
(In reply to comment #3)
> (From update of attachment 172495 [details])
> rs=me, assuming that this was a single Cmd+[ (or equivalent).

Indeed it was.  Thanks!
Comment 5 Filip Pizlo 2012-11-06 11:19:53 PST 
Landed in http://trac.webkit.org/changeset/133649