Bug 101306 - [Shadow] Use setPseudo() instead of setShadowPseudoId()
Summary: [Shadow] Use setPseudo() instead of setShadowPseudoId()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shinya Kawanaka
URL:
Keywords:
Depends on:
Blocks: 101171 101533
  Show dependency tree / graph
 
Reported: 2012-11-05 22:45 PST by Shinya Kawanaka
Modified: 2012-11-07 18:24 PST (History)
8 users (show)

See Also:

Attachments
WIP (22.21 KB, patch)
2012-11-06 00:11 PST, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
WIP (21.17 KB, patch)
2012-11-06 21:22 PST, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
Patch (22.16 KB, patch)
2012-11-06 23:00 PST, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2012-11-05 22:45:27 PST 
We would like to remove shadowPseudoId() and setShadowPseudoId() (Bug 101171).

In this bug, we would like to remove setShadowPseudoId() and use setPseudo instead.
Comment 1 Shinya Kawanaka 2012-11-06 00:11:22 PST 
Created attachment 172503 [details]
WIP
Comment 2 Build Bot 2012-11-06 01:46:37 PST 
Comment on attachment 172503 [details]
WIP

Attachment 172503 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14745300
Comment 3 Build Bot 2012-11-06 02:48:24 PST 
Comment on attachment 172503 [details]
WIP

Attachment 172503 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14747354
Comment 4 kov's GTK+ EWS bot 2012-11-06 02:59:00 PST 
Comment on attachment 172503 [details]
WIP

Attachment 172503 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/14660481
Comment 5 Shinya Kawanaka 2012-11-06 21:22:53 PST 
Created attachment 172713 [details]
WIP
Comment 6 Build Bot 2012-11-06 22:09:25 PST 
Comment on attachment 172713 [details]
WIP

Attachment 172713 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14761205
Comment 7 Build Bot 2012-11-06 22:26:19 PST 
Comment on attachment 172713 [details]
WIP

Attachment 172713 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14763078
Comment 8 Shinya Kawanaka 2012-11-06 23:00:26 PST 
Created attachment 172723 [details]
Patch
Comment 9 Kent Tamura 2012-11-07 00:48:57 PST 
Comment on attachment 172723 [details]
Patch

Looks ok
Comment 10 WebKit Review Bot 2012-11-07 06:13:57 PST 
Comment on attachment 172723 [details]
Patch

Clearing flags on attachment: 172723

Committed r133749: <http://trac.webkit.org/changeset/133749>
Comment 11 WebKit Review Bot 2012-11-07 06:14:01 PST 
All reviewed patches have been landed.  Closing bug.