Bug 101293 – [chromium] Expose CustomEvent through WebDOMCustomEvent.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sadrul Habib Chowdhury]

[chromium] Expose CustomEvent through WebDOMCustomEvent.

[Sadrul Habib Chowdhury]

Created attachment 172469 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Sadrul Habib Chowdhury]

Hi! This WebDOMCustomEvent is used for browser-plugin event dispatching. The chromium CL that uses this: http://codereview.chromium.org/11368071/

[Adam Barth]

Comment on attachment 172469 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172469&action=review

> Source/WebKit/chromium/src/WebDOMCustomEvent.cpp:49
> +    ScriptValue scriptValue = ScriptValue::deserialize(ScriptState::current(), serializedScriptValue.get());
> +    unwrap<CustomEvent>()->initCustomEvent(type, canBubble, cancelable, scriptValue);

This would be better if we could give the SerializedScriptValue to the CustomEvent and have it deserialize it when constructing the JavaScript wrapper.  That way we'll get a different deserialization for each world that has an event listener.

[Sadrul Habib Chowdhury]

Comment on attachment 172469 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172469&action=review

>> Source/WebKit/chromium/src/WebDOMCustomEvent.cpp:49
>> +    unwrap<CustomEvent>()->initCustomEvent(type, canBubble, cancelable, scriptValue);
> 
> This would be better if we could give the SerializedScriptValue to the CustomEvent and have it deserialize it when constructing the JavaScript wrapper.  That way we'll get a different deserialization for each world that has an event listener.

Addressed in https://bugs.webkit.org/show_bug.cgi?id=101348 If that looks good and lands, I will update this patch accordingly. Thanks!

[Sadrul Habib Chowdhury]

Created attachment 173343 [details]
Patch

[Adam Barth]

Comment on attachment 173343 [details]
Patch

This looks good.

[WebKit Review Bot]

Comment on attachment 173343 [details]
Patch

Attachment 173343 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14786312

[Sadrul Habib Chowdhury]

Comment on attachment 173343 [details]
Patch

The cq- from the bot happened since the patch this depends on hadn't landed yet. But now that that has landed, requesting cq

[WebKit Review Bot]

Comment on attachment 173343 [details]
Patch

Rejecting attachment 173343 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ediaControlsChromium.cpp:348: error: enumeration value 'MediaClosedCaptionsContainer' not handled in switch
Source/WebCore/rendering/RenderMediaControlsChromium.cpp:348: error: enumeration value 'MediaClosedCaptionsTrackList' not handled in switch
  CXX(target) out/Release/obj.target/webcore_rendering/Source/WebCore/rendering/RenderTheme.o
make: *** [out/Release/obj.target/webcore_rendering/Source/WebCore/rendering/RenderMediaControlsChromium.o] Error 1
make: *** Waiting for unfinished jobs....

Full output: http://queues.webkit.org/results/14788353

[Sadrul Habib Chowdhury]

Comment on attachment 173343 [details]
Patch

The failure is not caused by this CL :(

[Adam Barth]

That's true, but this one does:

Source/WebKit/chromium/src/WebDOMCustomEvent.cpp: In member function 'void WebKit::WebDOMCustomEvent::initCustomEvent(const WebKit::WebString&, bool, bool, const WebKit::WebSerializedScriptValue&)':
Source/WebKit/chromium/src/WebDOMCustomEvent.cpp:48: error: no matching function for call to 'WebCore::CustomEvent::initCustomEvent(const WebKit::WebString&, bool&, bool&, WebCore::SerializedScriptValue*)'
Source/WebCore/dom/CustomEvent.h:54: note: candidates are: void WebCore::CustomEvent::initCustomEvent(const WTF::AtomicString&, bool, bool, const WebCore::ScriptValue&)

[WebKit Review Bot]

Comment on attachment 173343 [details]
Patch

Clearing flags on attachment: 173343

Committed r134177: <http://trac.webkit.org/changeset/134177>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.