Bug 101275 - Clean up ScrollingConstraints.h
Summary: Clean up ScrollingConstraints.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Beth Dakin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-05 16:28 PST by Beth Dakin
Modified: 2012-11-05 16:48 PST (History)
7 users (show)

See Also:

Attachments
Patch (3.22 KB, patch)
2012-11-05 16:30 PST, Beth Dakin 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2012-11-05 16:28:04 PST 
Darin suggested a few small clean-ups to ScrollingConstraints.h here: https://bugs.webkit.org/show_bug.cgi?id=100796#c3 This bug tracks making the changes he suggested.
Comment 1 Beth Dakin 2012-11-05 16:30:46 PST 
Created attachment 172434 [details]
Patch
Comment 2 Simon Fraser (smfr) 2012-11-05 16:37:48 PST 
Comment on attachment 172434 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172434&action=review

> Source/WebCore/page/scrolling/ScrollingConstraints.h:-65
> -    ViewportConstraints()
> -        : m_anchorEdges(0)
> -    { }

You need this one to initialize m_anchorEdges, no?
Comment 3 Beth Dakin 2012-11-05 16:48:54 PST 
(In reply to comment #2)
> (From update of attachment 172434 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=172434&action=review
> 
> > Source/WebCore/page/scrolling/ScrollingConstraints.h:-65
> > -    ViewportConstraints()
> > -        : m_anchorEdges(0)
> > -    { }
> 
> You need this one to initialize m_anchorEdges, no?

Oops, yes!

Thank you!

http://trac.webkit.org/changeset/133542