RESOLVED FIXED 101267
Hook up the remote layer tree drawing area to an environment variable 
https://bugs.webkit.org/show_bug.cgi?id=101267
Summary Hook up the remote layer tree drawing area to an environment variable
Anders Carlsson
Reported 2012-11-05 15:20:32 PST
Hook up the remote layer tree drawing area to an environment variable
Attachments
Patch (2.66 KB, patch)
2012-11-05 15:21 PST, Anders Carlsson 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2012-11-05 15:21:02 PST
Created attachment 172418 [details] Patch
mitz
Comment 2 2012-11-05 15:24:16 PST
Comment on attachment 172418 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172418&action=review > Source/WebKit2/ChangeLog:9 > + (-[WKView WebKit::]): ? > Source/WebKit2/UIProcess/API/mac/WKView.mm:2282 > + if (getenv("WK_USE_REMOTE_LAYER_TREE_DRAWING_AREA")) User defaults offer greater flexibility and convenience over environment variables. Why did you choose to use an environment variable here?
Anders Carlsson
Comment 3 2012-11-05 16:15:51 PST
(In reply to comment #2) > (From update of attachment 172418 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=172418&action=review > > > Source/WebKit2/ChangeLog:9 > > + (-[WKView WebKit::]): > > ? ! > > > Source/WebKit2/UIProcess/API/mac/WKView.mm:2282 > > + if (getenv("WK_USE_REMOTE_LAYER_TREE_DRAWING_AREA")) > > User defaults offer greater flexibility and convenience over environment variables. Why did you choose to use an environment variable here? Because I don't want this to persist. I did the same thing when bringing up the tiled drawing area.
Andreas Kling
Comment 4 2012-11-06 10:32:04 PST
Comment on attachment 172418 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172418&action=review >>> Source/WebKit2/UIProcess/API/mac/WKView.mm:2282 >>> + if (getenv("WK_USE_REMOTE_LAYER_TREE_DRAWING_AREA")) >> >> User defaults offer greater flexibility and convenience over environment variables. Why did you choose to use an environment variable here? > > Because I don't want this to persist. I did the same thing when bringing up the tiled drawing area. fine.
Anders Carlsson
Comment 5 2012-11-06 10:43:14 PST
Committed r133637: <http://trac.webkit.org/changeset/133637>
Note You need to log in before you can comment on or make changes to this bug.