Bug 101238 - Fix asm operand type for weakCompareAndSwap on ARM_THUMB2
Summary: Fix asm operand type for weakCompareAndSwap on ARM_THUMB2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Wennborg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-05 11:27 PST by Hans Wennborg
Modified: 2012-11-07 12:48 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.24 KB, patch)
2012-11-05 11:35 PST, Hans Wennborg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Wennborg 2012-11-05 11:27:05 PST 
Fix asm operand type for weakCompareAndSwap on ARM_THUMB2
Comment 1 Hans Wennborg 2012-11-05 11:35:04 PST 
Created attachment 172369 [details]
Patch
Comment 2 Hans Wennborg 2012-11-05 11:39:22 PST 
Filip: would you like to take a look?
Comment 3 Hans Wennborg 2012-11-07 11:07:17 PST 
Ping?
Comment 4 Benjamin Poulain 2012-11-07 12:10:01 PST 
Comment on attachment 172369 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172369&action=review

> Source/WTF/ChangeLog:20
> +        Also make 'result' for the X86 version an 'unsigned char' to make it
> +        more clear that it is a byte.

I honestly have no clue about that one, but that seems consistent with the old code.
Comment 5 WebKit Review Bot 2012-11-07 12:48:18 PST 
Comment on attachment 172369 [details]
Patch

Clearing flags on attachment: 172369

Committed r133796: <http://trac.webkit.org/changeset/133796>
Comment 6 WebKit Review Bot 2012-11-07 12:48:22 PST 
All reviewed patches have been landed.  Closing bug.