Bug 101227 - [BlackBerry] Update touch code to reflect touch refactor
Summary: [BlackBerry] Update touch code to reflect touch refactor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-05 08:46 PST by gmak
Modified: 2012-11-05 11:10 PST (History)
1 user (show)

See Also:

Attachments
Patch with changelog (6.59 KB, patch)
2012-11-05 08:52 PST, gmak 		rwlbuis: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
patch - should apply cleanly now (6.57 KB, patch)
2012-11-05 10:33 PST, gmak 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description gmak 2012-11-05 08:46:09 PST 
Update interaction code.
Comment 1 gmak 2012-11-05 08:52:45 PST 
Created attachment 172344 [details]
Patch with changelog
Comment 2 Rob Buis 2012-11-05 08:57:11 PST 
Comment on attachment 172344 [details]
Patch with changelog

LGTM.
Comment 3 WebKit Review Bot 2012-11-05 08:58:29 PST 
Comment on attachment 172344 [details]
Patch with changelog

Rejecting attachment 172344 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Berry.cpp.rej
patching file Source/WebKit/blackberry/Api/WebPage.cpp
Hunk #1 succeeded at 4033 (offset -34 lines).
Hunk #2 succeeded at 4043 (offset -34 lines).
Hunk #3 succeeded at 4063 (offset -34 lines).
Hunk #4 succeeded at 4094 (offset -34 lines).
patching file Source/WebKit/blackberry/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14717822
Comment 4 gmak 2012-11-05 10:33:01 PST 
Created attachment 172358 [details]
patch - should apply cleanly now
Comment 5 Rob Buis 2012-11-05 10:35:20 PST 
Comment on attachment 172358 [details]
patch - should apply cleanly now

LGTM.
Comment 6 WebKit Review Bot 2012-11-05 11:10:21 PST 
Comment on attachment 172358 [details]
patch - should apply cleanly now

Clearing flags on attachment: 172358

Committed r133502: <http://trac.webkit.org/changeset/133502>
Comment 7 WebKit Review Bot 2012-11-05 11:10:25 PST 
All reviewed patches have been landed.  Closing bug.