WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
101227
[BlackBerry] Update touch code to reflect touch refactor
https://bugs.webkit.org/show_bug.cgi?id=101227
Summary
[BlackBerry] Update touch code to reflect touch refactor
gmak
Reported
2012-11-05 08:46:09 PST
Update interaction code.
Attachments
Patch with changelog
(6.59 KB, patch)
2012-11-05 08:52 PST
,
gmak
rwlbuis
: review+
webkit.review.bot
: commit-queue-
Details
Formatted Diff
Diff
patch - should apply cleanly now
(6.57 KB, patch)
2012-11-05 10:33 PST
,
gmak
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
gmak
Comment 1
2012-11-05 08:52:45 PST
Created
attachment 172344
[details]
Patch with changelog
Rob Buis
Comment 2
2012-11-05 08:57:11 PST
Comment on
attachment 172344
[details]
Patch with changelog LGTM.
WebKit Review Bot
Comment 3
2012-11-05 08:58:29 PST
Comment on
attachment 172344
[details]
Patch with changelog Rejecting
attachment 172344
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Berry.cpp.rej patching file Source/WebKit/blackberry/Api/WebPage.cpp Hunk #1 succeeded at 4033 (offset -34 lines). Hunk #2 succeeded at 4043 (offset -34 lines). Hunk #3 succeeded at 4063 (offset -34 lines). Hunk #4 succeeded at 4094 (offset -34 lines). patching file Source/WebKit/blackberry/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output:
http://queues.webkit.org/results/14717822
gmak
Comment 4
2012-11-05 10:33:01 PST
Created
attachment 172358
[details]
patch - should apply cleanly now
Rob Buis
Comment 5
2012-11-05 10:35:20 PST
Comment on
attachment 172358
[details]
patch - should apply cleanly now LGTM.
WebKit Review Bot
Comment 6
2012-11-05 11:10:21 PST
Comment on
attachment 172358
[details]
patch - should apply cleanly now Clearing flags on attachment: 172358 Committed
r133502
: <
http://trac.webkit.org/changeset/133502
>
WebKit Review Bot
Comment 7
2012-11-05 11:10:25 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug