Bug 101223 - [BlackBerry] ImageDiff build clean-up
Summary: [BlackBerry] ImageDiff build clean-up
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-05 08:05 PST by Ming Xie
Modified: 2014-01-28 08:15 PST (History)
7 users (show)

See Also:


Attachments
Patch (4.00 KB, patch)
2012-11-05 08:25 PST, Ming Xie
rwlbuis: review-
mxie: commit-queue?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ming Xie 2012-11-05 08:05:08 PST
We should put the ImageDiff build artifacts into the build folder instead of leaving it in Tools/

Also rename the build script to buildImageDiff.sh
Comment 1 Ming Xie 2012-11-05 08:25:38 PST
Created attachment 172338 [details]
Patch
Comment 2 Rob Buis 2012-11-05 08:41:10 PST
Comment on attachment 172338 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172338&action=review

Looks good, can be made a bit more robust.

> Tools/DumpRenderTree/blackberry/buildImageDiff.sh:6
> +OUTPUT_DIR="$RICHMOND_ROOT/webkit/WebKitBuild/ImageDiff"

It is probably better to abstract this a bit more and use the same build dir variable CMake uses. So I guess this script needs an argument for that.
Comment 3 Ming Xie 2012-11-05 09:04:44 PST
(In reply to comment #2)
> (From update of attachment 172338 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=172338&action=review
> 
> Looks good, can be made a bit more robust.
> 
> > Tools/DumpRenderTree/blackberry/buildImageDiff.sh:6
> > +OUTPUT_DIR="$RICHMOND_ROOT/webkit/WebKitBuild/ImageDiff"
> 
> It is probably better to abstract this a bit more and use the same build dir variable CMake uses. So I guess this script needs an argument for that.

Yeah, It may also be a good idea to not use QMake here. Let me re-think about this.