We should put the ImageDiff build artifacts into the build folder instead of leaving it in Tools/ Also rename the build script to buildImageDiff.sh
Created attachment 172338 [details] Patch
Comment on attachment 172338 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172338&action=review Looks good, can be made a bit more robust. > Tools/DumpRenderTree/blackberry/buildImageDiff.sh:6 > +OUTPUT_DIR="$RICHMOND_ROOT/webkit/WebKitBuild/ImageDiff" It is probably better to abstract this a bit more and use the same build dir variable CMake uses. So I guess this script needs an argument for that.
(In reply to comment #2) > (From update of attachment 172338 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=172338&action=review > > Looks good, can be made a bit more robust. > > > Tools/DumpRenderTree/blackberry/buildImageDiff.sh:6 > > +OUTPUT_DIR="$RICHMOND_ROOT/webkit/WebKitBuild/ImageDiff" > > It is probably better to abstract this a bit more and use the same build dir variable CMake uses. So I guess this script needs an argument for that. Yeah, It may also be a good idea to not use QMake here. Let me re-think about this.