Bug 101205 - [EFL][WK2] Make Ewk_Url_Request, Ewk_Url_Response, Ewk_Navigation_Data Ewk_Objects
Summary: [EFL][WK2] Make Ewk_Url_Request, Ewk_Url_Response, Ewk_Navigation_Data Ewk_O...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords:
Depends on:
Blocks: 101057
  Show dependency tree / graph
 
Reported: 2012-11-05 03:46 PST by Mikhail Pozdnyakov
Modified: 2012-11-05 04:39 PST (History)
5 users (show)

See Also:

Attachments
patch (27.89 KB, patch)
2012-11-05 03:51 PST, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
patch (27.89 KB, patch)
2012-11-05 03:54 PST, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2012-11-05 03:46:55 PST 
Make Ewk_Url_Request, Ewk_Url_Response, Ewk_Navigation_Data Ewk_Objects as part of bug101057 work.
Comment 1 Mikhail Pozdnyakov 2012-11-05 03:51:25 PST 
Created attachment 172312 [details]
patch
Comment 2 Mikhail Pozdnyakov 2012-11-05 03:54:30 PST 
Created attachment 172313 [details]
patch

fixed '*' on wrong side.
Comment 3 Chris Dumez 2012-11-05 03:56:29 PST 
Comment on attachment 172313 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172313&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_navigation_policy_decision_private.h:60
> +    EwkUrlRequest* request() const;

We should probably make this getter non-const (although this can be done in a separate patch).
Comment 4 Mikhail Pozdnyakov 2012-11-05 03:59:15 PST 
(In reply to comment #3)
> (From update of attachment 172313 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=172313&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_navigation_policy_decision_private.h:60
> > +    EwkUrlRequest* request() const;
> 
> We should probably make this getter non-const (although this can be done in a separate patch).

We should make a big work to fix constness inside WK2 EFL, currently it's all very messy. Off course this is out if this patch's scope.
Comment 5 WebKit Review Bot 2012-11-05 04:39:30 PST 
Comment on attachment 172313 [details]
patch

Clearing flags on attachment: 172313

Committed r133457: <http://trac.webkit.org/changeset/133457>
Comment 6 WebKit Review Bot 2012-11-05 04:39:34 PST 
All reviewed patches have been landed.  Closing bug.