Bug 101204 – Expose hit test related methods in public chromium port

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Bo Liu]

Expose hit test related methods in public chromium port

[Bo Liu]

Created attachment 172306 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Bo Liu]

Created attachment 172308 [details]
Add Changelog

[Adam Barth]

Comment on attachment 172308 [details]
Add Changelog

View in context: https://bugs.webkit.org/attachment.cgi?id=172308&action=review

> Source/WebKit/chromium/public/WebHitTestResult.h:67
> +    WEBKIT_EXPORT WebElement URLElement() const;
> +
> +    WEBKIT_EXPORT WebURL absoluteImageURL() const;
> +
> +    WEBKIT_EXPORT WebURL absoluteLinkURL() const;
> +
> +    WEBKIT_EXPORT bool isContentEditable() const;

Please add comments explaining what this function do.  Also URLElement is not in correct style.  Perhaps urlElement?

[Bo Liu]

Created attachment 172355 [details]
Add comments. URLElement -> urlElement

[Adam Barth]

Comment on attachment 172355 [details]
Add comments. URLElement -> urlElement

View in context: https://bugs.webkit.org/attachment.cgi?id=172355&action=review

> Source/WebKit/chromium/src/WebHitTestResult.cpp:54
> +WebElement WebHitTestResult::URLElement() const

Does this compile?

[Bo Liu]

Created attachment 172356 [details]
Fix compile (also rename method in cpp file)

[Bo Liu]

(In reply to comment #6)
> (From update of attachment 172355 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=172355&action=review
> 
> > Source/WebKit/chromium/src/WebHitTestResult.cpp:54
> > +WebElement WebHitTestResult::URLElement() const
> 
> Does this compile?

No of course not. Thanks for catching my mistake!!

Also fyi, URLElement (uppercase URL) is in WebCore::HitTestResult

[Adam Barth]

> Also fyi, URLElement (uppercase URL) is in WebCore::HitTestResult

If you're inclined, you might consider writing a follow-up patch to fix that.  :)

[WebKit Review Bot]

Comment on attachment 172356 [details]
Fix compile (also rename method in cpp file)

Clearing flags on attachment: 172356

Committed r133503: <http://trac.webkit.org/changeset/133503>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.