Bug 101200 – Web Inspector: make Spectrum and Popover WebInspector.Views in order to enable reuse

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

- Split Spectrum and SpectrumPopoverHelper (first is a component, second it controller)
- Made Popover a root view in order to enable lazy style loading for potential subviews (such as Spectrum)
- Extracted spectrum's css into a separate file

[Pavel Feldman]

Created attachment 172301 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 172301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172301&action=review

> Source/WebCore/ChangeLog:8
> +        - Split Spectrum and SpectrumPopoverHelper (first is a component, second it controller)

typo: second it controller -> second is its controller

> Source/WebCore/inspector/front-end/DOMExtension.js:208
> +function Size(width, height)

Why not WebInspector.Size to make it clear that it is not from Web API?

> Source/WebCore/inspector/front-end/View.js:372
> +        this.element.positionAt(undefined, undefined);

Why not reuse Element.measurePreferredSize and simply call this.element.measurePreferredSize() here instead?

[Pavel Feldman]

> typo: second it controller -> second is its controller


Done

> 
> > Source/WebCore/inspector/front-end/DOMExtension.js:208
> > +function Size(width, height)
> 
> Why not WebInspector.Size to make it clear that it is not from Web API?
> 

I'm adding it into DOMExtension which is compiled outside of inspector. I did not want to invent a namespace for it.

> > Source/WebCore/inspector/front-end/View.js:372
> > +        this.element.positionAt(undefined, undefined);
> 
> Why not reuse Element.measurePreferredSize and simply call this.element.measurePreferredSize() here instead?

Because we can't operate on View's elements using regular DOM operations.

[Pavel Feldman]

Committed r133582: <http://trac.webkit.org/changeset/133582>