Bug 101197 – [EFL] Fix build warning in EWebLauncher/main.c

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[KyungTae Kim]

For fixing the follow build warnings :
/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/EWebLauncher/main.c:941:9: warning: initialization from incompatible pointer type [enabled by default]
/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/EWebLauncher/main.c:941:9: warning: (near initialization for ‘values[0].strp’) [enabled by default]
/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/EWebLauncher/main.c:943:9: warning: initialization from incompatible pointer type [enabled by default]
/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/EWebLauncher/main.c:943:9: warning: (near initialization for ‘values[2].strp’) [enabled by default]
/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/EWebLauncher/main.c:948:9: warning: initialization from incompatible pointer type [enabled by default]
/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/EWebLauncher/main.c:948:9: warning: (near initialization for ‘values[7].strp’) [enabled by default]
/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/EWebLauncher/main.c:949:9: warning: initialization from incompatible pointer type [enabled by default]
/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/EWebLauncher/main.c:949:9: warning: (near initialization for ‘values[8].strp’) [enabled by default]


The destination for ECORE_GETOPT_VALUE_STR is char**, but the source is  &(const char*).
One of them need to be fixed.

//Ecore_Getopt.h
union _Ecore_Getopt_Value
{
   char          **strp;
..
};

[KyungTae Kim]

Created attachment 172298 [details]
Patch

[Kentaro Hara]

Comment on attachment 172298 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172298&action=review

> Tools/EWebLauncher/main.c:146
> +    char *engine;

According to the WebKit coding style, this should be 'char* engine' instead of 'char *engine'. Same comments for the following variables.

[Gyuyoung Kim]

Comment on attachment 172298 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172298&action=review

>> Tools/EWebLauncher/main.c:146
>> +    char *engine;
> 
> According to the WebKit coding style, this should be 'char* engine' instead of 'char *engine'. Same comments for the following variables.

Kentaro, this is EFL simple application. So, we follow EFL coding style for EWebLauncher.

[Kentaro Hara]

Comment on attachment 172298 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172298&action=review

>>> Tools/EWebLauncher/main.c:146
>>> +    char *engine;
>> 
>> According to the WebKit coding style, this should be 'char* engine' instead of 'char *engine'. Same comments for the following variables.
> 
> Kentaro, this is EFL simple application. So, we follow EFL coding style for EWebLauncher.

Makes sense. Thanks for the clarification.

[WebKit Review Bot]

Comment on attachment 172298 [details]
Patch

Clearing flags on attachment: 172298

Committed r133452: <http://trac.webkit.org/changeset/133452>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.