We currently experience crashes in WebKitTestRunner because the icon database path can only be set once. The WebKitTestRunner is now setting the icon database path (Bug 100678) and we set it a second time in ewk_context. We should stop setting the path in ewk_context and let the client take care of it to avoid this issue.
Created attachment 172276 [details] Patch
Comment on attachment 172276 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172276&action=review > Source/WebKit2/UIProcess/API/efl/ewk_favicon_database.cpp:43 > + : m_iconDatabase(iconDatabase) Nit : two spaces ? > Tools/ChangeLog:3 > + 101182_iconDatabase_path What is this ? > Tools/ChangeLog:10 > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). Add patch description
Created attachment 172280 [details] Patch Take Gyuyoung's feedback into consideration. I completely missed to update one changelog entry after generating it. Thanks for catching it.
Comment on attachment 172280 [details] Patch Clearing flags on attachment: 172280 Committed r133442: <http://trac.webkit.org/changeset/133442>
All reviewed patches have been landed. Closing bug.