Bug 101178 – [Shadow] ShadowRoot should have a method to return ShadowRootType

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Shinya Kawanaka]

We would like to reject using pseudo id starting '-webkit-' in AuthorShadowRoot. However, we have to accept it in UA ShadowRoot.

So we have to know ShadowRootType now.

[Shinya Kawanaka]

Created attachment 172272 [details]
Patch

[Hajime Morrita]

Comment on attachment 172272 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172272&action=review

> Source/WebCore/dom/ShadowRoot.h:119
> +    ShadowRootType m_type : 1;

Is it possible to ensure that ShadowRootType can be fit into a bit?
Is STATIC_ASSERT or something helpful here?

[Shinya Kawanaka]

Comment on attachment 172272 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172272&action=review

>> Source/WebCore/dom/ShadowRoot.h:119
>> +    ShadowRootType m_type : 1;
> 
> Is it possible to ensure that ShadowRootType can be fit into a bit?
> Is STATIC_ASSERT or something helpful here?

I've tried adding extra enum item into ShadowRootType, then gcc complained that m_type field is too small.
So I don't think we have to do something special here.

[WebKit Review Bot]

Comment on attachment 172272 [details]
Patch

Clearing flags on attachment: 172272

Committed r133435: <http://trac.webkit.org/changeset/133435>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.