Bug 101164 - Web Inspector: render message bubbles in CodeMirror experiment.
Summary: Web Inspector: render message bubbles in CodeMirror experiment.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-04 02:27 PST by Pavel Feldman
Modified: 2012-11-05 05:43 PST (History)
9 users (show)

See Also:

Attachments
Patch (6.69 KB, patch)
2012-11-04 02:47 PST, Pavel Feldman 		no flags Details | Formatted Diff | Diff
[Patch] for landing (6.97 KB, patch)
2012-11-05 05:02 PST, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-11-04 02:27:49 PST 
It sounds like addLineWidget just makes it happen.
Comment 1 Pavel Feldman 2012-11-04 02:47:52 PST 
Created attachment 172243 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-11-05 02:44:14 PST 
Comment on attachment 172243 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172243&action=review

> Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:65
> +    this._widgets = [];

Looks like this._widgets is redundant, you only use it to iterate over all widgets but this could be done using this._elementToWidget.

> Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:186
> +            this._codeMirror.removeLineWidget(widget);

Shouldn't we remove an entry from elementToWidget map as well here?
Comment 3 Pavel Feldman 2012-11-05 05:02:37 PST 
Created attachment 172316 [details]
[Patch] for landing
Comment 4 WebKit Review Bot 2012-11-05 05:43:37 PST 
Comment on attachment 172316 [details]
[Patch] for landing

Clearing flags on attachment: 172316

Committed r133460: <http://trac.webkit.org/changeset/133460>
Comment 5 WebKit Review Bot 2012-11-05 05:43:41 PST 
All reviewed patches have been landed.  Closing bug.