101149 – Reduce amount of code that includes StylePropertySet.h.

RESOLVED FIXED 101149

Reduce amount of code that includes StylePropertySet.h.

https://bugs.webkit.org/show_bug.cgi?id=101149

Summary Reduce amount of code that includes StylePropertySet.h.

Andreas Kling

Reported 2012-11-03 09:06:48 PDT

SSIA

Attachments
For EWS (27.31 KB, patch) 2012-11-03 14:05 PDT, Andreas Kling	buildbot: commit-queue-	Details Formatted Diff Diff
For EWS II: The Breakening (26.20 KB, patch) 2012-11-04 01:52 PST, Andreas Kling	no flags	Details Formatted Diff Diff
For EWS II: The Breakening [REPACK] (28.62 KB, patch) 2012-11-04 01:53 PST, Andreas Kling	gtk-ews: commit-queue-	Details Formatted Diff Diff
For EWS III: Tonight We Paint the Bots Red (10.83 KB, patch) 2013-02-23 20:07 PST, Andreas Kling	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
For EWS IV: A New Hope (11.45 KB, patch) 2013-02-23 20:38 PST, Andreas Kling	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
For EWS V: It was Roy the Paramedic all along. (11.70 KB, patch) 2013-02-23 21:23 PST, Andreas Kling	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
For EWS VI: Jason Lives (12.82 KB, patch) 2013-02-23 21:45 PST, Andreas Kling	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
For EWS VII: Clever Title Like Deadmau5 Would Use (33.74 KB, patch) 2013-02-23 22:51 PST, Andreas Kling	eflews.bot: commit-queue-	Details Formatted Diff Diff
For EWS VIII: StylePropertySet Takes Manhattan (29.40 KB, patch) 2013-02-25 05:16 PST, Andreas Kling	eflews.bot: commit-queue-	Details Formatted Diff Diff
For EWS IX: The One That Actually Worked(?) (30.46 KB, patch) 2013-02-25 05:47 PST, Andreas Kling	no flags	Details Formatted Diff Diff
Patch (36.34 KB, patch) 2013-02-25 07:15 PST, Andreas Kling	koivisto: review+	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2012-11-03 14:05:25 PDT

Created attachment 172227 [details] For EWS

WebKit Review Bot

Comment 2 2012-11-03 14:07:44 PDT

Attachment 172227 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/dom/ElementAttributeData.h:69: The parameter name "style" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/html/parser/XSSAuditor.h:32: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/rendering/RenderTableCell.cpp:29: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/dom/Attr.cpp:30: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/svg/SVGAnimateElement.cpp:32: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/dom/ElementAttributeData.cpp:33: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/dom/StyledElement.h:29: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 7 in 37 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 3 2012-11-03 14:39:38 PDT

Comment on attachment 172227 [details] For EWS Attachment 172227 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14733071

Peter Beverloo (cr-android ews)

Comment 4 2012-11-03 14:41:24 PDT

Comment on attachment 172227 [details] For EWS Attachment 172227 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14733067

Build Bot

Comment 5 2012-11-03 14:54:06 PDT

Comment on attachment 172227 [details] For EWS Attachment 172227 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14732075

WebKit Review Bot

Comment 6 2012-11-03 14:55:14 PDT

Comment on attachment 172227 [details] For EWS Attachment 172227 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14713378

EFL EWS Bot

Comment 7 2012-11-03 14:55:59 PDT

Comment on attachment 172227 [details] For EWS Attachment 172227 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14728143

kov's GTK+ EWS bot

Comment 8 2012-11-03 15:16:14 PDT

Comment on attachment 172227 [details] For EWS Attachment 172227 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/14731095

EFL EWS Bot

Comment 9 2012-11-03 15:21:38 PDT

Comment on attachment 172227 [details] For EWS Attachment 172227 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14733079

Early Warning System Bot

Comment 10 2012-11-03 15:27:03 PDT

Comment on attachment 172227 [details] For EWS Attachment 172227 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14726259

Build Bot

Comment 11 2012-11-03 15:39:50 PDT

Comment on attachment 172227 [details] For EWS Attachment 172227 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14732083

WebKit Review Bot

Comment 12 2012-11-03 15:46:10 PDT

Comment on attachment 172227 [details] For EWS Attachment 172227 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14728156

Build Bot

Comment 13 2012-11-03 15:52:02 PDT

Comment on attachment 172227 [details] For EWS Attachment 172227 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14720274

Peter Beverloo (cr-android ews)

Comment 14 2012-11-03 16:43:50 PDT

Comment on attachment 172227 [details] For EWS Attachment 172227 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14720289

kov's GTK+ EWS bot

Comment 15 2012-11-04 01:10:12 PST

Comment on attachment 172240 [details] For EWS II: The Breakening [REPACK] Attachment 172240 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/14721425

Andreas Kling

Comment 16 2012-11-04 01:52:37 PST

Created attachment 172239 [details] For EWS II: The Breakening

Andreas Kling

Comment 17 2012-11-04 01:53:34 PST

Created attachment 172240 [details] For EWS II: The Breakening [REPACK]

WebKit Review Bot

Comment 18 2012-11-04 01:55:26 PST

Attachment 172240 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/bindings/js/JSCSSFontFaceRu..." exit_code: 1 Source/WebCore/dom/ElementAttributeData.h:69: The parameter name "style" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/html/parser/XSSAuditor.h:32: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/rendering/RenderTableCell.cpp:29: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/dom/Attr.cpp:30: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/svg/SVGAnimateElement.cpp:32: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/dom/ElementAttributeData.cpp:33: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/dom/StyledElement.h:29: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 7 in 42 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andreas Kling

Comment 19 2013-02-23 20:07:33 PST

Created attachment 189952 [details] For EWS III: Tonight We Paint the Bots Red

WebKit Review Bot

Comment 20 2013-02-23 20:10:25 PST

Attachment 189952 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/bindings/js/JSDOMBinding.h', u'Source/WebCore/css/StyleRule.cpp', u'Source/WebCore/css/WebKitCSSKeyframeRule.h', u'Source/WebCore/dom/Attr.cpp', u'Source/WebCore/dom/StyledElement.cpp', u'Source/WebCore/dom/StyledElement.h', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLElement.h', u'Source/WebCore/html/HTMLFontElement.cpp', u'Source/WebCore/html/HTMLHRElement.cpp', u'Source/WebCore/html/HTMLPreElement.cpp', u'Source/WebCore/html/HTMLTableElement.cpp', u'Source/WebCore/html/HTMLTablePartElement.cpp', u'Source/WebCore/html/shadow/MediaControlElementTypes.cpp', u'Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm']" exit_code: 1 Source/WebCore/dom/Attr.cpp:30: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/dom/StyledElement.h:28: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 21 2013-02-23 20:25:40 PST

Comment on attachment 189952 [details] For EWS III: Tonight We Paint the Bots Red Attachment 189952 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16732166

WebKit Review Bot

Comment 22 2013-02-23 20:35:30 PST

Comment on attachment 189952 [details] For EWS III: Tonight We Paint the Bots Red Attachment 189952 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16733135

Andreas Kling

Comment 23 2013-02-23 20:38:02 PST

Created attachment 189953 [details] For EWS IV: A New Hope

WebKit Review Bot

Comment 24 2013-02-23 20:56:27 PST

Attachment 189953 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/bindings/js/JSDOMBinding.h', u'Source/WebCore/css/StyleRule.cpp', u'Source/WebCore/css/WebKitCSSKeyframeRule.cpp', u'Source/WebCore/css/WebKitCSSKeyframeRule.h', u'Source/WebCore/dom/Attr.cpp', u'Source/WebCore/dom/StyledElement.cpp', u'Source/WebCore/dom/StyledElement.h', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLElement.h', u'Source/WebCore/html/HTMLFontElement.cpp', u'Source/WebCore/html/HTMLHRElement.cpp', u'Source/WebCore/html/HTMLPreElement.cpp', u'Source/WebCore/html/HTMLTableElement.cpp', u'Source/WebCore/html/HTMLTablePartElement.cpp', u'Source/WebCore/html/shadow/MediaControlElementTypes.cpp', u'Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm']" exit_code: 1 Source/WebCore/dom/Attr.cpp:30: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/dom/StyledElement.h:28: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 25 2013-02-23 21:13:07 PST

Comment on attachment 189953 [details] For EWS IV: A New Hope Attachment 189953 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16738079

WebKit Review Bot

Comment 26 2013-02-23 21:15:40 PST

Comment on attachment 189953 [details] For EWS IV: A New Hope Attachment 189953 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16738080

Andreas Kling

Comment 27 2013-02-23 21:23:38 PST

Created attachment 189957 [details] For EWS V: It was Roy the Paramedic all along.

WebKit Review Bot

Comment 28 2013-02-23 21:40:21 PST

Comment on attachment 189957 [details] For EWS V: It was Roy the Paramedic all along. Attachment 189957 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16732195

Andreas Kling

Comment 29 2013-02-23 21:45:35 PST

Created attachment 189958 [details] For EWS VI: Jason Lives

WebKit Review Bot

Comment 30 2013-02-23 22:03:15 PST

Comment on attachment 189958 [details] For EWS VI: Jason Lives Attachment 189958 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16730220

WebKit Review Bot

Comment 31 2013-02-23 22:10:29 PST

Comment on attachment 189958 [details] For EWS VI: Jason Lives Attachment 189958 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16727254

Andreas Kling

Comment 32 2013-02-23 22:51:14 PST

Created attachment 189959 [details] For EWS VII: Clever Title Like Deadmau5 Would Use

WebKit Review Bot

Comment 33 2013-02-23 22:54:24 PST

Attachment 189959 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/bindings/js/JSDOMBinding.h', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/CSSComputedStyleDeclaration.h', u'Source/WebCore/css/CSSStyleDeclaration.h', u'Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp', u'Source/WebCore/css/PropertySetCSSStyleDeclaration.h', u'Source/WebCore/css/SelectorChecker.h', u'Source/WebCore/css/SelectorCheckerFastPath.cpp', u'Source/WebCore/css/SelectorFilter.cpp', u'Source/WebCore/css/SelectorFilter.h', u'Source/WebCore/css/StylePropertySet.cpp', u'Source/WebCore/css/StylePropertySet.h', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/css/StyleResolver.h', u'Source/WebCore/css/StyleRule.cpp', u'Source/WebCore/css/WebKitCSSKeyframeRule.cpp', u'Source/WebCore/css/WebKitCSSKeyframeRule.h', u'Source/WebCore/dom/Attr.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/StyledElement.cpp', u'Source/WebCore/dom/StyledElement.h', u'Source/WebCore/editing/FrameSelection.cpp', u'Source/WebCore/editing/RemoveCSSPropertyCommand.cpp', u'Source/WebCore/editing/RemoveCSSPropertyCommand.h', u'Source/WebCore/editing/RemoveFormatCommand.cpp', u'Source/WebCore/editing/mac/EditorMac.mm', u'Source/WebCore/html/HTMLBodyElement.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLElement.h', u'Source/WebCore/html/HTMLFontElement.cpp', u'Source/WebCore/html/HTMLHRElement.cpp', u'Source/WebCore/html/HTMLPreElement.cpp', u'Source/WebCore/html/HTMLTableElement.cpp', u'Source/WebCore/html/HTMLTablePartElement.cpp', u'Source/WebCore/html/canvas/CanvasStyle.cpp', u'Source/WebCore/html/shadow/MediaControlElementTypes.cpp', u'Source/WebCore/inspector/InspectorStyleSheet.cpp', u'Source/WebCore/page/PageSerializer.cpp', u'Source/WebCore/rendering/RenderTableCell.cpp', u'Source/WebCore/svg/SVGAnimateElement.cpp', u'Source/WebCore/svg/SVGElementRareData.h', u'Source/WebCore/svg/SVGFontFaceElement.cpp', u'Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit2/Shared/WebRenderObject.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp']" exit_code: 1 Source/WebCore/svg/SVGAnimateElement.cpp:32: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 47 files If any of these errors are false positives, please file a bug against check-webkit-style.

EFL EWS Bot

Comment 34 2013-02-23 23:07:46 PST

Comment on attachment 189959 [details] For EWS VII: Clever Title Like Deadmau5 Would Use Attachment 189959 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/16732243

WebKit Review Bot

Comment 35 2013-02-23 23:10:27 PST

Comment on attachment 189959 [details] For EWS VII: Clever Title Like Deadmau5 Would Use Attachment 189959 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16736173

WebKit Review Bot

Comment 36 2013-02-23 23:23:29 PST

Comment on attachment 189959 [details] For EWS VII: Clever Title Like Deadmau5 Would Use Attachment 189959 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16733243

kov's GTK+ EWS bot

Comment 37 2013-02-23 23:49:03 PST

Comment on attachment 189959 [details] For EWS VII: Clever Title Like Deadmau5 Would Use Attachment 189959 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/16726312

Andreas Kling

Comment 38 2013-02-25 05:16:27 PST

Created attachment 190038 [details] For EWS VIII: StylePropertySet Takes Manhattan

WebKit Review Bot

Comment 39 2013-02-25 05:19:45 PST

Attachment 190038 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/CSSComputedStyleDeclaration.h', u'Source/WebCore/css/CSSStyleDeclaration.h', u'Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp', u'Source/WebCore/css/PropertySetCSSStyleDeclaration.h', u'Source/WebCore/css/SelectorChecker.h', u'Source/WebCore/css/SelectorCheckerFastPath.cpp', u'Source/WebCore/css/SelectorFilter.cpp', u'Source/WebCore/css/SelectorFilter.h', u'Source/WebCore/css/StylePropertySet.cpp', u'Source/WebCore/css/StylePropertySet.h', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/css/StyleResolver.h', u'Source/WebCore/css/StyleRule.cpp', u'Source/WebCore/css/WebKitCSSKeyframeRule.cpp', u'Source/WebCore/css/WebKitCSSKeyframeRule.h', u'Source/WebCore/dom/Attr.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/StyledElement.cpp', u'Source/WebCore/dom/StyledElement.h', u'Source/WebCore/editing/FrameSelection.cpp', u'Source/WebCore/editing/RemoveCSSPropertyCommand.cpp', u'Source/WebCore/editing/RemoveCSSPropertyCommand.h', u'Source/WebCore/editing/RemoveFormatCommand.cpp', u'Source/WebCore/html/HTMLBodyElement.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLElement.h', u'Source/WebCore/html/HTMLFontElement.cpp', u'Source/WebCore/html/HTMLHRElement.cpp', u'Source/WebCore/html/HTMLPreElement.cpp', u'Source/WebCore/html/HTMLTableElement.cpp', u'Source/WebCore/html/HTMLTablePartElement.cpp', u'Source/WebCore/html/canvas/CanvasStyle.cpp', u'Source/WebCore/html/shadow/MediaControlElementTypes.cpp', u'Source/WebCore/inspector/InspectorStyleSheet.cpp', u'Source/WebCore/page/PageSerializer.cpp', u'Source/WebCore/rendering/RenderTableCell.cpp', u'Source/WebCore/svg/SVGAnimateElement.cpp', u'Source/WebCore/svg/SVGElementRareData.h', u'Source/WebCore/svg/SVGFontFaceElement.cpp', u'Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp']" exit_code: 1 Source/WebCore/svg/SVGAnimateElement.cpp:32: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 45 files If any of these errors are false positives, please file a bug against check-webkit-style.

EFL EWS Bot

Comment 40 2013-02-25 05:36:05 PST

Comment on attachment 190038 [details] For EWS VIII: StylePropertySet Takes Manhattan Attachment 190038 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/16747221

WebKit Review Bot

Comment 41 2013-02-25 05:41:49 PST

Comment on attachment 190038 [details] For EWS VIII: StylePropertySet Takes Manhattan Attachment 190038 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16744245

Andreas Kling

Comment 42 2013-02-25 05:47:35 PST

Created attachment 190043 [details] For EWS IX: The One That Actually Worked(?)

Andreas Kling

Comment 43 2013-02-25 07:15:35 PST

Created attachment 190051 [details] Patch Let's do this.

WebKit Review Bot

Comment 44 2013-02-25 07:21:51 PST

Attachment 190051 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/CSSComputedStyleDeclaration.h', u'Source/WebCore/css/CSSStyleDeclaration.h', u'Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp', u'Source/WebCore/css/PropertySetCSSStyleDeclaration.h', u'Source/WebCore/css/SelectorChecker.h', u'Source/WebCore/css/SelectorCheckerFastPath.cpp', u'Source/WebCore/css/SelectorFilter.cpp', u'Source/WebCore/css/SelectorFilter.h', u'Source/WebCore/css/StylePropertySet.cpp', u'Source/WebCore/css/StylePropertySet.h', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/css/StyleResolver.h', u'Source/WebCore/css/StyleRule.cpp', u'Source/WebCore/css/ViewportStyleResolver.cpp', u'Source/WebCore/css/ViewportStyleResolver.h', u'Source/WebCore/css/WebKitCSSKeyframeRule.cpp', u'Source/WebCore/css/WebKitCSSKeyframeRule.h', u'Source/WebCore/dom/Attr.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/StyledElement.cpp', u'Source/WebCore/dom/StyledElement.h', u'Source/WebCore/editing/FrameSelection.cpp', u'Source/WebCore/editing/RemoveCSSPropertyCommand.cpp', u'Source/WebCore/editing/RemoveCSSPropertyCommand.h', u'Source/WebCore/editing/RemoveFormatCommand.cpp', u'Source/WebCore/html/HTMLBodyElement.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLElement.h', u'Source/WebCore/html/HTMLFontElement.cpp', u'Source/WebCore/html/HTMLHRElement.cpp', u'Source/WebCore/html/HTMLPreElement.cpp', u'Source/WebCore/html/HTMLTableElement.cpp', u'Source/WebCore/html/HTMLTablePartElement.cpp', u'Source/WebCore/html/canvas/CanvasStyle.cpp', u'Source/WebCore/html/shadow/MediaControlElementTypes.cpp', u'Source/WebCore/inspector/InspectorStyleSheet.cpp', u'Source/WebCore/page/PageSerializer.cpp', u'Source/WebCore/rendering/RenderTableCell.cpp', u'Source/WebCore/svg/SVGAnimateElement.cpp', u'Source/WebCore/svg/SVGElementRareData.h', u'Source/WebCore/svg/SVGFontFaceElement.cpp', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp']" exit_code: 1 Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp:41: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 52 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andreas Kling

Comment 45 2013-02-25 07:51:33 PST

Committed r143926: <http://trac.webkit.org/changeset/143926>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version 528+ (Nightly build)

Hardware Unspecified

OS Unspecified

Product WebKit

Component CSS

Assignee

Andreas Kling

Reported

2012-11-03 09:06 PDT

Modified

2013-02-25 07:51 PST History

CC List

25 users Show

URL

Keywords

Depends on

Blocks

allan.jensen
cmarcelo
dbates
dglazkov
d-r
eric.carlson
eric
esprehn+autocc
feature-media-reviews
fmalita
gtk-ews
gustavo
jer.noble
kling
macpherson
menard
mifenton
ojan.autocc
pdr
peter+ews
philn
rego+ews
schenney
webkit.review.bot
xan.lopez