Renamed inline header files from ...InlineMethods.h to ...Inlines.h. There are no semantic changes, only renames.
Created attachment 172212 [details] the patch. The patch has no functionality changes. Only renamed the relevant inline header, and fixed up all the #includes to reference the new names. Also fixed up the #include order in 5 files to keep the style checker happy. Going to run the patch thru the EWS bots first. Will submit for review if it passes the builds on all bots.
Attachment 172212 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSObjectRef.cpp'..." exit_code: 1 Source/JavaScriptCore/heap/MarkStackInlines.h:40: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Source/JavaScriptCore/heap/MarkStackInlines.h:47: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Source/JavaScriptCore/runtime/JSValueInlines.h:33: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 3 in 83 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > Attachment 172212 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSObjectRef.cpp'..." exit_code: 1 > Source/JavaScriptCore/heap/MarkStackInlines.h:40: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] > Source/JavaScriptCore/heap/MarkStackInlines.h:47: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] > Source/JavaScriptCore/runtime/JSValueInlines.h:33: Code inside a namespace should not be indented. [whitespace/indent] [4] > Total errors found: 3 in 83 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. These were pre-existing conditions in the files before I renamed them. The 2 lines in MarkStackInlines.h are just spaces in empty lines. I will remove them before I commit. On the other hand, JSValueInlines.h has indentation for all the inline methods in the file. To fix this, I will have to change the indentation of the entire file. So, I'll just leave it as is instead.
Will wait for http://webkit.org/b/98606 and http://webkit.org/b/101127 to minimize merge complications.
Created attachment 173144 [details] Updated patch.
Created attachment 173147 [details] svn up'ed again.
Created attachment 173157 [details] Removed file that has been obsoleted by other changes during the svn up's.
Attachment 173157 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSObjectRef.cpp'..." exit_code: 1 Source/JavaScriptCore/runtime/JSValueInlines.h:33: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 64 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 173157 [details] Removed file that has been obsoleted by other changes during the svn up's. The style error came from the file I renamed. Will not fix it in this patch so as to keep the change minimal and restricted to this renaming task. Ready for a review now.
Comment on attachment 173157 [details] Removed file that has been obsoleted by other changes during the svn up's. r=me Please make sure to watch the builders when this lands.
Landed in r133995: <http://trac.webkit.org/changeset/133995>.