WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 101138
REGRESSION(
r133375
): Caused 3 tests to fail on Mac (Requested by aboxhall-laptop on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=101138
Summary
REGRESSION(r133375): Caused 3 tests to fail on Mac (Requested by aboxhall-lap...
WebKit Review Bot
Reported
2012-11-02 18:21:26 PDT
http://trac.webkit.org/changeset/133375
broke the build: Caused 3 tests to fail on Mac (Requested by aboxhall-laptop on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Attachments
ROLLOUT of r133375
(460.14 KB, patch)
2012-11-02 18:22 PDT
,
WebKit Review Bot
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
WebKit Review Bot
Comment 1
2012-11-02 18:22:19 PDT
Created
attachment 172191
[details]
ROLLOUT of
r133375
Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Eric Seidel (no email)
Comment 2
2012-11-02 18:32:15 PDT
It appears as though the original patch had some custom results for chromium-linux, but not other chromium ports. These are all ref tests. Mysteriously, the two which are failing are custom results only for chromium-linux. It seems that we should move those to either chromium or right next to the original tests. In either case, we will need Glenn to confirm the results. We can roll this out or not. It doesn't really matter.
Eric Seidel (no email)
Comment 3
2012-11-02 18:32:40 PDT
http://build.webkit.org/TestFailures/garden-o-matic.html
is only showing me 2 failures. Whre is the 3rd?
WebKit Review Bot
Comment 4
2012-11-02 18:49:01 PDT
Comment on
attachment 172191
[details]
ROLLOUT of
r133375
Clearing flags on attachment: 172191 Committed
r133386
: <
http://trac.webkit.org/changeset/133386
>
WebKit Review Bot
Comment 5
2012-11-02 18:49:05 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug