Bug 101138 - REGRESSION(r133375): Caused 3 tests to fail on Mac (Requested by aboxhall-laptop on #webkit).
Summary: REGRESSION(r133375): Caused 3 tests to fail on Mac (Requested by aboxhall-lap...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Review Bot
URL:
Keywords:
Depends on:
Blocks: 89235
  Show dependency treegraph
 
Reported: 2012-11-02 18:21 PDT by WebKit Review Bot
Modified: 2012-11-02 18:49 PDT (History)
2 users (show)

See Also:


Attachments
ROLLOUT of r133375 (460.14 KB, patch)
2012-11-02 18:22 PDT, WebKit Review Bot
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2012-11-02 18:21:26 PDT
http://trac.webkit.org/changeset/133375 broke the build:
Caused 3 tests to fail on Mac (Requested by aboxhall-laptop on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2012-11-02 18:22:19 PDT
Created attachment 172191 [details]
ROLLOUT of r133375

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Eric Seidel (no email) 2012-11-02 18:32:15 PDT
It appears as though the original patch had some custom results for chromium-linux, but not other chromium ports.

These are all ref tests.  Mysteriously, the two which are failing are custom results only for chromium-linux.

It seems that we should move those to either chromium or right next to the original tests.

In either case, we will need Glenn to confirm the results.

We can roll this out or not.  It doesn't really matter.
Comment 3 Eric Seidel (no email) 2012-11-02 18:32:40 PDT
http://build.webkit.org/TestFailures/garden-o-matic.html is only showing me 2 failures. Whre is the 3rd?
Comment 4 WebKit Review Bot 2012-11-02 18:49:01 PDT
Comment on attachment 172191 [details]
ROLLOUT of r133375

Clearing flags on attachment: 172191

Committed r133386: <http://trac.webkit.org/changeset/133386>
Comment 5 WebKit Review Bot 2012-11-02 18:49:05 PDT
All reviewed patches have been landed.  Closing bug.