WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
101124
LineBreakIteratorPoolICU should use a class or std::pair instead of a String as the hash-key for the pool
https://bugs.webkit.org/show_bug.cgi?id=101124
Summary
LineBreakIteratorPoolICU should use a class or std::pair instead of a String ...
Eric Seidel (no email)
Reported
2012-11-02 16:25:34 PDT
LineBreakIteratorPoolICU should use a class or std::pair instead of a String as the hash-key for the pool
bug 89235
introduces a somewhat odd system of encoding the loose/strict breaking variant as part of the locale string which is used by the pool as a key. It would be cleaner to have ICU-agnostic logic to parse out the locale and break variant and then pass them around as class instead of encoded in the string. I believe this would require either defining a HashTraits for the new class, or using std::pair<AtomicString, LineBreakIteratorMode> which I believe already has generic HashTraits to do the right thing. :)
Attachments
Add attachment
proposed patch, testcase, etc.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug