Bug 101124 - LineBreakIteratorPoolICU should use a class or std::pair instead of a String as the hash-key for the pool
Summary: LineBreakIteratorPoolICU should use a class or std::pair instead of a String ...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Glenn Adams
URL:
Keywords:
Depends on: 89235
Blocks:
  Show dependency tree / graph
 
Reported: 2012-11-02 16:25 PDT by Eric Seidel (no email)
Modified: 2012-11-02 16:31 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2012-11-02 16:25:34 PDT 
LineBreakIteratorPoolICU should use a class or std::pair instead of a String as the hash-key for the pool

bug 89235 introduces a somewhat odd system of encoding the loose/strict breaking variant as part of the locale string which is used by the pool as a key.

It would be cleaner to have ICU-agnostic logic to parse out the locale and break variant and then pass them around as class instead of encoded in the string.

I believe this would require either defining a HashTraits for the new class, or using std::pair<AtomicString, LineBreakIteratorMode>  which I believe already has generic HashTraits to do the right thing. :)