Bug 101111 - [Mac] ResourceHandle changes for network process
Summary: [Mac] ResourceHandle changes for network process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-02 15:14 PDT by Alexey Proskuryakov
Modified: 2012-11-05 15:13 PST (History)
2 users (show)

See Also:

Attachments
proposed patch (9.27 KB, patch)
2012-11-02 15:27 PDT, Alexey Proskuryakov 		jberlin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2012-11-02 15:14:52 PDT 
Patch forthcoming.
Comment 1 Alexey Proskuryakov 2012-11-02 15:27:28 PDT 
Created attachment 172159 [details]
proposed patch
Comment 2 Jessie Berlin 2012-11-02 16:00:32 PDT 
Comment on attachment 172159 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172159&action=review

> Source/WebCore/ChangeLog:7
> +

It would be good to give a short summary of why we want to use an NSOperationQueue here over scheduling with the run loop.

> Source/WebCore/ChangeLog:11
> +        Add an ability to schedul on an NSOperationQueue. Now that scheduling on run loop

Typo: "schedul"

> Source/WebCore/platform/network/NetworkingContext.h:27
>  #include "SchedulePair.h"

Nit pick: Don't we always put forward declarations after #includes?
Comment 3 Alexey Proskuryakov 2012-11-02 16:11:56 PDT 
Committed <http://trac.webkit.org/changeset/133366>.
Comment 4 Alexey Proskuryakov 2012-11-05 15:13:05 PST 
> Nit pick: Don't we always put forward declarations after #includes?

I meant to change the header accordingly, but committed without saving this file. Will fix later.