Bug 101106 – lint-webkitpy doesn't autoinstall pylint properly

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dirk Pranke]

lint-webkitpy doesn't autoinstall pylint properly

[Dirk Pranke]

Created attachment 172147 [details]
Patch

[Dirk Pranke]

Committed r133381: <http://trac.webkit.org/changeset/133381>

[WebKit Review Bot]

Re-opened since this is blocked by bug 101161

[Csaba Osztrogonác]

(In reply to comment #2)
> Committed r133381: <http://trac.webkit.org/changeset/133381>

Rolled out by r133414, because it broke autoinstaller and webkit-patch indirectly:

$ Tools/Scripts/webkit-patch --help
Traceback (most recent call last):
  File "Tools/Scripts/webkit-patch", line 44, in <module>
    from webkitpy.tool.main import WebKitPatch
  File "/home/oszi/WebKit/Tools/Scripts/webkitpy/tool/main.py", line 38, in <module>
    from webkitpy.common.net.irc import ircproxy
  File "/home/oszi/WebKit/Tools/Scripts/webkitpy/common/net/irc/ircproxy.py", line 31, in <module>
    from webkitpy.common.net.irc.ircbot import IRCBot
  File "/home/oszi/WebKit/Tools/Scripts/webkitpy/common/net/irc/ircbot.py", line 32, in <module>
    from webkitpy.thirdparty.autoinstalled.irc import ircbot
  File "/home/oszi/WebKit/Tools/Scripts/webkitpy/thirdparty/__init__.py", line 91, in find_module
    self._install_irc()
  File "/home/oszi/WebKit/Tools/Scripts/webkitpy/thirdparty/__init__.py", line 150, in _install_irc
    url_subpath="irclib.py")
  File "/home/oszi/WebKit/Tools/Scripts/webkitpy/common/system/autoinstall.py", line 406, in install
    raise Exception(message)
Exception: Error auto-installing the irclib.py package to:
 "/home/oszi/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/irc/irclib.py"
 --> Inner message: 'AutoInstaller' object has no attribute '_make_package'

[Csaba Osztrogonác]

Comment on attachment 172147 [details]
Patch

remove r+ from landed and rolled out patch.

[Dirk Pranke]

Thanks, Ossy! Sorry for the trouble.

Re-landed w/ fix in http://trac.webkit.org/changeset/133504 .