RESOLVED FIXED101102
Don't instantiate the Java plug-in if it's inactive 
https://bugs.webkit.org/show_bug.cgi?id=101102
Summary Don't instantiate the Java plug-in if it's inactive
Anders Carlsson
Reported 2012-11-02 14:29:29 PDT
Don't instantiate the Java plug-in if it's inactive
Attachments
Patch (348.79 KB, patch)
2012-11-02 14:54 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (348.59 KB, patch)
2012-11-02 15:17 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (348.61 KB, patch)
2012-11-02 15:47 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (348.62 KB, patch)
2012-11-02 16:06 PDT, Anders Carlsson 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2012-11-02 14:54:37 PDT
Created attachment 172146 [details] Patch
WebKit Review Bot
Comment 2 2012-11-02 14:59:03 PDT
Attachment 172146 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/mac/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:477: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebKit2/WebProcess/WebPage/WebPage.cpp:513: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] WebKitLibraries/WebKitSystemInterface.h:165: The parameter name "font" adds no information, so it should be removed. [readability/parameter_name] [5] WebKitLibraries/WebKitSystemInterface.h:165: The parameter name "options" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 4 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 3 2012-11-02 15:10:11 PDT
Comment on attachment 172146 [details] Patch Attachment 172146 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14714069
Anders Carlsson
Comment 4 2012-11-02 15:17:21 PDT
Created attachment 172154 [details] Patch
WebKit Review Bot
Comment 5 2012-11-02 15:21:38 PDT
Attachment 172154 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/mac/ChangeLog', u'Source/Web..." exit_code: 1 WebKitLibraries/WebKitSystemInterface.h:165: The parameter name "font" adds no information, so it should be removed. [readability/parameter_name] [5] WebKitLibraries/WebKitSystemInterface.h:165: The parameter name "options" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 6 2012-11-02 15:39:34 PDT
Comment on attachment 172154 [details] Patch Attachment 172154 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14693983
Anders Carlsson
Comment 7 2012-11-02 15:47:22 PDT
Created attachment 172161 [details] Patch
WebKit Review Bot
Comment 8 2012-11-02 15:50:37 PDT
Attachment 172161 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/mac/ChangeLog', u'Source/Web..." exit_code: 1 WebKitLibraries/WebKitSystemInterface.h:165: The parameter name "font" adds no information, so it should be removed. [readability/parameter_name] [5] WebKitLibraries/WebKitSystemInterface.h:165: The parameter name "options" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 9 2012-11-02 16:05:23 PDT
Comment on attachment 172161 [details] Patch Attachment 172161 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14697817
Anders Carlsson
Comment 10 2012-11-02 16:06:14 PDT
Created attachment 172166 [details] Patch
WebKit Review Bot
Comment 11 2012-11-02 16:09:00 PDT
Attachment 172166 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/mac/ChangeLog', u'Source/Web..." exit_code: 1 WebKitLibraries/WebKitSystemInterface.h:165: The parameter name "font" adds no information, so it should be removed. [readability/parameter_name] [5] WebKitLibraries/WebKitSystemInterface.h:165: The parameter name "options" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 12 2012-11-02 16:35:09 PDT
Comment on attachment 172166 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172166&action=review r=me > WebKitLibraries/ChangeLog:14 > + Roll WebKitSystemInterface DEPS. I believe the technical term is DERPS.
Anders Carlsson
Comment 13 2012-11-02 16:36:00 PDT
(In reply to comment #12) > (From update of attachment 172166 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=172166&action=review > > r=me > > > WebKitLibraries/ChangeLog:14 > > + Roll WebKitSystemInterface DEPS. > > I believe the technical term is DERPS. Otay!
Anders Carlsson
Comment 14 2012-11-02 16:39:50 PDT
Committed r133371: <http://trac.webkit.org/changeset/133371>
Note You need to log in before you can comment on or make changes to this bug.