101102 – Don't instantiate the Java plug-in if it's inactive

Bug 101102 - Don't instantiate the Java plug-in if it's inactive

Summary: Don't instantiate the Java plug-in if it's inactive

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Anders Carlsson

URL:
Keywords:

Depends on:
Blocks:

Reported:	2012-11-02 14:29 PDT by Anders Carlsson
Modified:	2012-11-02 16:39 PDT (History)
CC List:	1 user (show)

See Also:

Attachments
Patch (348.79 KB, patch) 2012-11-02 14:54 PDT, Anders Carlsson	no flags	Details \| Formatted Diff \| Diff
Patch (348.59 KB, patch) 2012-11-02 15:17 PDT, Anders Carlsson	no flags	Details \| Formatted Diff \| Diff
Patch (348.61 KB, patch) 2012-11-02 15:47 PDT, Anders Carlsson	no flags	Details \| Formatted Diff \| Diff
Patch (348.62 KB, patch) 2012-11-02 16:06 PDT, Anders Carlsson	kling: review+	Details \| Formatted Diff \| Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Anders Carlsson 2012-11-02 14:29:29 PDT

Don't instantiate the Java plug-in if it's inactive

Comment 1 Anders Carlsson 2012-11-02 14:54:37 PDT

Created attachment 172146 [details]
Patch

Comment 2 WebKit Review Bot 2012-11-02 14:59:03 PDT

Attachment 172146 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/mac/ChangeLog', u'Source/Web..." exit_code: 1
Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:477:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Source/WebKit2/WebProcess/WebPage/WebPage.cpp:513:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
WebKitLibraries/WebKitSystemInterface.h:165:  The parameter name "font" adds no information, so it should be removed.  [readability/parameter_name] [5]
WebKitLibraries/WebKitSystemInterface.h:165:  The parameter name "options" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 4 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Early Warning System Bot 2012-11-02 15:10:11 PDT

Comment on attachment 172146 [details]
Patch

Attachment 172146 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14714069

Comment 4 Anders Carlsson 2012-11-02 15:17:21 PDT

Created attachment 172154 [details]
Patch

Comment 5 WebKit Review Bot 2012-11-02 15:21:38 PDT

Attachment 172154 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/mac/ChangeLog', u'Source/Web..." exit_code: 1
WebKitLibraries/WebKitSystemInterface.h:165:  The parameter name "font" adds no information, so it should be removed.  [readability/parameter_name] [5]
WebKitLibraries/WebKitSystemInterface.h:165:  The parameter name "options" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 6 Early Warning System Bot 2012-11-02 15:39:34 PDT

Comment on attachment 172154 [details]
Patch

Attachment 172154 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14693983

Comment 7 Anders Carlsson 2012-11-02 15:47:22 PDT

Created attachment 172161 [details]
Patch

Comment 8 WebKit Review Bot 2012-11-02 15:50:37 PDT

Attachment 172161 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/mac/ChangeLog', u'Source/Web..." exit_code: 1
WebKitLibraries/WebKitSystemInterface.h:165:  The parameter name "font" adds no information, so it should be removed.  [readability/parameter_name] [5]
WebKitLibraries/WebKitSystemInterface.h:165:  The parameter name "options" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 9 Early Warning System Bot 2012-11-02 16:05:23 PDT

Comment on attachment 172161 [details]
Patch

Attachment 172161 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14697817

Comment 10 Anders Carlsson 2012-11-02 16:06:14 PDT

Created attachment 172166 [details]
Patch

Comment 11 WebKit Review Bot 2012-11-02 16:09:00 PDT

Attachment 172166 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/mac/ChangeLog', u'Source/Web..." exit_code: 1
WebKitLibraries/WebKitSystemInterface.h:165:  The parameter name "font" adds no information, so it should be removed.  [readability/parameter_name] [5]
WebKitLibraries/WebKitSystemInterface.h:165:  The parameter name "options" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 12 Andreas Kling 2012-11-02 16:35:09 PDT

Comment on attachment 172166 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172166&action=review

r=me

> WebKitLibraries/ChangeLog:14
> +        Roll WebKitSystemInterface DEPS.

I believe the technical term is DERPS.

Comment 13 Anders Carlsson 2012-11-02 16:36:00 PDT

(In reply to comment #12)
> (From update of attachment 172166 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=172166&action=review
> 
> r=me
> 
> > WebKitLibraries/ChangeLog:14
> > +        Roll WebKitSystemInterface DEPS.
> 
> I believe the technical term is DERPS.

Otay!

Comment 14 Anders Carlsson 2012-11-02 16:39:50 PDT

Committed r133371: <http://trac.webkit.org/changeset/133371>