Bug 101091 - EWS bots have stopped uploading results to bugzilla
Summary: EWS bots have stopped uploading results to bugzilla
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-02 12:57 PDT by Eric Seidel (no email)
Modified: 2013-03-21 00:32 PDT (History)
4 users (show)

See Also:


Attachments
Fixes the bug (6.61 KB, patch)
2013-03-20 21:25 PDT, Ryosuke Niwa
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2012-11-02 12:57:33 PDT
EWS bots have stopped uploading results to bugzilla

We may have disabled this intentionally, I can't remember.

This should be the code:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py#L90
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/commands/queues.py#L241

It may also be the size-cap code in bugzilla that we're hitting?

There was an effort a while back to make the layout-test-results.zip files smaller.  I suspect they're just too large for bugzilla to handle.  Most of the time they should only be a few k!  I suspect we'll need to use our LayoutTestResults object to whitelist which results we copy in to the zip.
Comment 1 Ojan Vafai 2012-11-02 13:18:00 PDT
I think we never made the change to only copy unexpected failures into the zip. That's the key thing to making the zips small.
Comment 2 Dirk Pranke 2012-11-02 13:49:06 PDT
The EWS bots run with --skip-failing-tests, so they don't have the expected failures regardless.
Comment 3 Eric Seidel (no email) 2012-11-02 14:23:01 PDT
We already parse results.json and expose that via LayoutTestResults so we could easily build a white-listed copy function in python (and then either use it in NRWT or the EWS or both).
Comment 4 Ojan Vafai 2012-11-02 14:25:31 PDT
(In reply to comment #2)
> The EWS bots run with --skip-failing-tests, so they don't have the expected failures regardless.

Oh right. That should cover everything except flaky tests.
Comment 5 Dirk Pranke 2012-11-02 14:58:24 PDT
I expect there's a bunch of other less-than-useful stuff we could prune as well, like the tests_run* files and the web server logs.
Comment 6 Ryosuke Niwa 2013-03-20 21:25:36 PDT
Created attachment 194179 [details]
Fixes the bug
Comment 7 Ryosuke Niwa 2013-03-21 00:32:45 PDT
Committed r146443: <http://trac.webkit.org/changeset/146443>