Bug 101086 - [CSS Exclusions] Implement text alignment for shape-inside
Summary: [CSS Exclusions] Implement text alignment for shape-inside
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bear Travis
Depends on:
Blocks: 89256
  Show dependency treegraph
Reported: 2012-11-02 12:17 PDT by Bear Travis
Modified: 2013-06-17 11:54 PDT (History)
3 users (show)

See Also:

Initial Patch, Adding Tests (8.68 KB, patch)
2013-06-13 16:29 PDT, Bear Travis
no flags Details | Formatted Diff | Diff
Fixing style issues (8.69 KB, patch)
2013-06-13 16:34 PDT, Bear Travis
achicu: review+
Details | Formatted Diff | Diff
Minor adjustment (8.66 KB, patch)
2013-06-14 16:03 PDT, Bear Travis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bear Travis 2012-11-02 12:17:53 PDT
Specifically for multi-segment polygons, this can be complex.
Comment 1 Alan Stearns 2013-02-20 07:26:55 PST
Add tests for all alignments (particularly justified) with this fix.
Comment 2 Bear Travis 2013-06-13 16:29:23 PDT
Created attachment 204651 [details]
Initial Patch, Adding Tests
Comment 3 WebKit Commit Bot 2013-06-13 16:31:17 PDT
Attachment 204651 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/exclusions/resources/multi-segment-polygon.js', u'LayoutTests/fast/exclusions/shape-inside/shape-inside-text-align-expected.html', u'LayoutTests/fast/exclusions/shape-inside/shape-inside-text-align.html']" exit_code: 1
LayoutTests/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 4 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Bear Travis 2013-06-13 16:34:41 PDT
Created attachment 204652 [details]
Fixing style issues
Comment 5 Alexandru Chiculita 2013-06-14 14:25:49 PDT
Comment on attachment 204652 [details]
Fixing style issues

View in context: https://bugs.webkit.org/attachment.cgi?id=204652&action=review

looks good.

> LayoutTests/fast/exclusions/shape-inside/shape-inside-text-align-expected.html:6
> +<script>
> +</script>

nit: you forgot this empty script.
Comment 6 Bear Travis 2013-06-14 16:03:41 PDT
Created attachment 204741 [details]
Minor adjustment
Comment 7 WebKit Commit Bot 2013-06-17 11:54:16 PDT
Comment on attachment 204741 [details]
Minor adjustment

Clearing flags on attachment: 204741

Committed r151650: <http://trac.webkit.org/changeset/151650>
Comment 8 WebKit Commit Bot 2013-06-17 11:54:18 PDT
All reviewed patches have been landed.  Closing bug.