Bug 101083 - [BlackBerry] Optimize backspace key handling
Summary: [BlackBerry] Optimize backspace key handling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nima Ghanavatian
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-02 12:09 PDT by Nima Ghanavatian
Modified: 2012-11-02 14:12 PDT (History)
5 users (show)

See Also:


Attachments
Patch (4.23 KB, patch)
2012-11-02 12:36 PDT, Nima Ghanavatian
no flags Details | Formatted Diff | Diff
Patch (4.39 KB, patch)
2012-11-02 13:21 PDT, Nima Ghanavatian
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nima Ghanavatian 2012-11-02 12:09:26 PDT
We can reduce the number of messages sent back and fourth on every backspace key by eliminating those going to the input_service.
Comment 1 Nima Ghanavatian 2012-11-02 12:36:18 PDT
Created attachment 172111 [details]
Patch
Comment 2 Yong Li 2012-11-02 13:06:52 PDT
Comment on attachment 172111 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172111&action=review

> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1494
> +        if (m_receivedBackspaceKeyDown)
> +            m_receivedBackspaceKeyDown = false;

the "if" is not needed in this case

> Source/WebKit/blackberry/WebKitSupport/InputHandler.h:229
> +    bool m_receivedBackspaceKeyDown;

initialize in the ctor?
Comment 3 Nima Ghanavatian 2012-11-02 13:21:43 PDT
Created attachment 172123 [details]
Patch
Comment 4 WebKit Review Bot 2012-11-02 14:12:06 PDT
Comment on attachment 172123 [details]
Patch

Clearing flags on attachment: 172123

Committed r133343: <http://trac.webkit.org/changeset/133343>
Comment 5 WebKit Review Bot 2012-11-02 14:12:09 PDT
All reviewed patches have been landed.  Closing bug.