Bug 101082 - [BlackBerry] ResourceHandle::cancel() in ResourceHandleBlackBerry should setClient to null.
Summary: [BlackBerry] ResourceHandle::cancel() in ResourceHandleBlackBerry should setC...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2012-11-02 12:05 PDT by Lyon Chen
Modified: 2012-11-02 14:08 PDT (History)
6 users (show)

See Also:

patch for 101082 (1.71 KB, patch)
2012-11-02 13:02 PDT, Lyon Chen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lyon Chen 2012-11-02 12:05:36 PDT
In ResourceHandleBlackBerry, ResourceHandle::cancel() doesn't call setClient(0), which could leave a window that its client can still be called, after it is cancelled. This should be avoided.
Comment 1 Lyon Chen 2012-11-02 13:02:42 PDT
Created attachment 172120 [details]
patch for 101082
Comment 2 Lyon Chen 2012-11-02 13:03:42 PDT
+ Yong, Joe, Rob.
Comment 3 Yong Li 2012-11-02 13:31:30 PDT
Comment on attachment 172120 [details]
patch for 101082

I think it is good. ResourceLoader doesn't do this when it cancels the job:

        if (m_handle) {
            m_handle = 0;
Comment 4 WebKit Review Bot 2012-11-02 14:08:14 PDT
Comment on attachment 172120 [details]
patch for 101082

Clearing flags on attachment: 172120

Committed r133341: <http://trac.webkit.org/changeset/133341>
Comment 5 WebKit Review Bot 2012-11-02 14:08:18 PDT
All reviewed patches have been landed.  Closing bug.