WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
101082
[BlackBerry] ResourceHandle::cancel() in ResourceHandleBlackBerry should setClient to null.
https://bugs.webkit.org/show_bug.cgi?id=101082
Summary
[BlackBerry] ResourceHandle::cancel() in ResourceHandleBlackBerry should setC...
Lyon Chen
Reported
2012-11-02 12:05:36 PDT
In ResourceHandleBlackBerry, ResourceHandle::cancel() doesn't call setClient(0), which could leave a window that its client can still be called, after it is cancelled. This should be avoided.
Attachments
patch for 101082
(1.71 KB, patch)
2012-11-02 13:02 PDT
,
Lyon Chen
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Lyon Chen
Comment 1
2012-11-02 13:02:42 PDT
Created
attachment 172120
[details]
patch for 101082
Lyon Chen
Comment 2
2012-11-02 13:03:42 PDT
+ Yong, Joe, Rob.
Yong Li
Comment 3
2012-11-02 13:31:30 PDT
Comment on
attachment 172120
[details]
patch for 101082 I think it is good. ResourceLoader doesn't do this when it cancels the job: if (m_handle) { m_handle->cancel(); m_handle = 0; }
WebKit Review Bot
Comment 4
2012-11-02 14:08:14 PDT
Comment on
attachment 172120
[details]
patch for 101082 Clearing flags on attachment: 172120 Committed
r133341
: <
http://trac.webkit.org/changeset/133341
>
WebKit Review Bot
Comment 5
2012-11-02 14:08:18 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug