Bug 101077 – [GTK] Clean up includes in GObject DOM bindings code

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

There are some headers included multiple times and some inconsistencies in the includes.

[Carlos Garcia Campos]

Created attachment 172095 [details]
Patch

[Kentaro Hara]

Comment on attachment 172095 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172095&action=review

Looks OK. Let's land it after making EWS bots green.

> Source/WebCore/ChangeLog:24
> +        * bindings/scripts/CodeGeneratorGObject.pm:

No need to update run-bindings-tests?

[Carlos Garcia Campos]

(In reply to comment #2)
> (From update of attachment 172095 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=172095&action=review
> 
> Looks OK. Let's land it after making EWS bots green.
> 
> > Source/WebCore/ChangeLog:24
> > +        * bindings/scripts/CodeGeneratorGObject.pm:
> 
> No need to update run-bindings-tests?

Yes, I dind't know there were tests for the bindings :-P I'm updating the results for all the patches now. Thanks!

[Kentaro Hara]

(In reply to comment #3)
> Yes, I dind't know there were tests for the bindings :-P I'm updating the results for all the patches now. Thanks!

See here: https://trac.webkit.org/wiki/WebKitIDL#RunBindingsTests

[Carlos Garcia Campos]

Created attachment 172106 [details]
Updated patch to include test results

[Martin Robinson]

Comment on attachment 172106 [details]
Updated patch to include test results

View in context: https://bugs.webkit.org/attachment.cgi?id=172106&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1437
>      # Remove the implementation header from the list of included files.

It looks like this comment can be removed now?

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1438
>      %includesCopy = %implIncludes;

Maybe we don't have to make a copy if we don't do the deletion?

[Carlos Garcia Campos]

Committed r133893: <http://trac.webkit.org/changeset/133893>