Bug 101072 - [GTK] Simplify GObject DOM bindings code for handling properties
Summary: [GTK] Simplify GObject DOM bindings code for handling properties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 101074
  Show dependency tree / graph
 
Reported: 2012-11-02 11:15 PDT by Carlos Garcia Campos
Modified: 2012-12-04 01:43 PST (History)
8 users (show)

See Also:

Attachments
Patch (7.53 KB, patch)
2012-11-02 11:22 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Updated patch including new test results (38.72 KB, patch)
2012-11-02 12:08 PDT, Carlos Garcia Campos 		xan.lopez: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2012-11-02 11:15:20 PDT 
We can avoid some GObject boilerplate by not defining get/set_property methods when the object doesn't have properties, or writable properties.
Comment 1 Carlos Garcia Campos 2012-11-02 11:22:20 PDT 
Created attachment 172091 [details]
Patch
Comment 2 Carlos Garcia Campos 2012-11-02 12:08:06 PDT 
Created attachment 172102 [details]
Updated patch including new test results
Comment 3 Xan Lopez 2012-12-01 02:36:12 PST 
Comment on attachment 172102 [details]
Updated patch including new test results

Yeah, looks great.
Comment 4 Carlos Garcia Campos 2012-12-04 01:43:10 PST 
Committed r136491: <http://trac.webkit.org/changeset/136491>