Bug 101065 - Web Inspector: JavaScript web workers debugging crashes
Summary: Web Inspector: JavaScript web workers debugging crashes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-02 09:02 PDT by Yury Semikhatsky
Modified: 2012-11-06 00:49 PST (History)
8 users (show)

See Also:

Attachments
Patch (1.37 KB, patch)
2012-11-02 09:07 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Patch (10.21 KB, patch)
2012-11-05 22:28 PST, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Patch (10.82 KB, patch)
2012-11-06 00:29 PST, Yury Semikhatsky 		apavlov: review+
apavlov: commit-queue+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-11-02 09:02:54 PDT 
Original Chromium bug report: http://code.google.com/p/chromium/issues/detail?id=153913

Repro steps:

1. Open attached page, enable debugger tools with {Workers.Pause on start}
2. Continue from the top debugging screen (press start, or just close the window)
3. Crash
Comment 1 Yury Semikhatsky 2012-11-02 09:07:00 PDT 
Created attachment 172076 [details]
Patch
Comment 2 Yury Semikhatsky 2012-11-05 22:28:07 PST 
Created attachment 172488 [details]
Patch
Comment 3 Yury Semikhatsky 2012-11-05 22:28:40 PST 
(In reply to comment #2)
> Created an attachment (id=172488) [details]
> Patch

Added layout test.
Comment 4 Alexander Pavlov (apavlov) 2012-11-05 23:45:50 PST 
Comment on attachment 172488 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172488&action=review

> LayoutTests/inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html:31
> +                             "id": workerRequestId++ }

closing brace could be aligned with its opening counterpart, like anywhere else
Comment 5 Yury Semikhatsky 2012-11-05 23:49:00 PST 
(In reply to comment #4)
> (From update of attachment 172488 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=172488&action=review
> 
> > LayoutTests/inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html:31
> > +                             "id": workerRequestId++ }
> 
> closing brace could be aligned with its opening counterpart, like anywhere else

Done.
Comment 6 Yury Semikhatsky 2012-11-06 00:29:46 PST 
Created attachment 172505 [details]
Patch
Comment 7 Yury Semikhatsky 2012-11-06 00:49:49 PST 
Committed r133569: <http://trac.webkit.org/changeset/133569>