Bug 101061 - [EFL][WK2]Minibrowser forgets http variables when url includes ampersand
Summary: [EFL][WK2]Minibrowser forgets http variables when url includes ampersand
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jussi Kukkonen (jku)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-02 08:39 PDT by Jussi Kukkonen (jku)
Modified: 2012-11-06 04:15 PST (History)
5 users (show)

See Also:


Attachments
Patch (2.06 KB, patch)
2012-11-02 08:51 PDT, Jussi Kukkonen (jku)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jussi Kukkonen (jku) 2012-11-02 08:39:35 PDT
It seems Elementary entry thinks it's supposed to mangle input and output. If user inputs an ampersand sign, that is turned into "&" in the elm_entry_entry_get() output. This will in effect drop every http variable after the first.

I'll attach a patch.
Comment 1 Jussi Kukkonen (jku) 2012-11-02 08:51:27 PDT
Created attachment 172068 [details]
Patch
Comment 2 Jussi Kukkonen (jku) 2012-11-02 08:57:23 PDT
It seems it's not possible to tell the entry we don't need this entry processing: I just asked on #e and using markup_to_utf8 is apparently the correct way to handle this.
Comment 3 Chris Dumez 2012-11-02 09:06:55 PDT
Comment on attachment 172068 [details]
Patch

Have you tried:
elm_object_part_text_get(entry, "default") / elm_object_part_text_set(entry, "default", url) ?
Comment 4 Jussi Kukkonen (jku) 2012-11-05 01:17:35 PST
(In reply to comment #3)
> (From update of attachment 172068 [details])
> Have you tried:
> elm_object_part_text_get(entry, "default") / elm_object_part_text_set(entry, "default", url) ?

This feature is actually implemented in elm_object IIRC so that probably won't help. I'll test anyway.
Comment 5 Jussi Kukkonen (jku) 2012-11-05 04:20:46 PST
(In reply to comment #4)
> This feature is actually implemented in elm_object IIRC so that probably won't help. 

Confirming that elm_object_part_text_get/set works the same way, it returns the escaped string which we do not want.
Comment 6 Chris Dumez 2012-11-05 04:24:18 PST
(In reply to comment #5)
> (In reply to comment #4)
> > This feature is actually implemented in elm_object IIRC so that probably won't help. 
> 
> Confirming that elm_object_part_text_get/set works the same way, it returns the escaped string which we do not want.

Ok, thanks for checking. LGTM then.
Comment 7 WebKit Review Bot 2012-11-06 04:14:56 PST
Comment on attachment 172068 [details]
Patch

Clearing flags on attachment: 172068

Committed r133585: <http://trac.webkit.org/changeset/133585>
Comment 8 WebKit Review Bot 2012-11-06 04:15:00 PST
All reviewed patches have been landed.  Closing bug.