Bug 101061 – [EFL][WK2]Minibrowser forgets http variables when url includes ampersand

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jussi Kukkonen (jku)]

It seems Elementary entry thinks it's supposed to mangle input and output. If user inputs an ampersand sign, that is turned into "&" in the elm_entry_entry_get() output. This will in effect drop every http variable after the first.

I'll attach a patch.

[Jussi Kukkonen (jku)]

Created attachment 172068 [details]
Patch

[Jussi Kukkonen (jku)]

It seems it's not possible to tell the entry we don't need this entry processing: I just asked on #e and using markup_to_utf8 is apparently the correct way to handle this.

[Chris Dumez]

Comment on attachment 172068 [details]
Patch

Have you tried:
elm_object_part_text_get(entry, "default") / elm_object_part_text_set(entry, "default", url) ?

[Jussi Kukkonen (jku)]

(In reply to comment #3)
> (From update of attachment 172068 [details])
> Have you tried:
> elm_object_part_text_get(entry, "default") / elm_object_part_text_set(entry, "default", url) ?

This feature is actually implemented in elm_object IIRC so that probably won't help. I'll test anyway.

[Jussi Kukkonen (jku)]

(In reply to comment #4)
> This feature is actually implemented in elm_object IIRC so that probably won't help. 

Confirming that elm_object_part_text_get/set works the same way, it returns the escaped string which we do not want.

[Chris Dumez]

(In reply to comment #5)
> (In reply to comment #4)
> > This feature is actually implemented in elm_object IIRC so that probably won't help. 
> 
> Confirming that elm_object_part_text_get/set works the same way, it returns the escaped string which we do not want.

Ok, thanks for checking. LGTM then.

[WebKit Review Bot]

Comment on attachment 172068 [details]
Patch

Clearing flags on attachment: 172068

Committed r133585: <http://trac.webkit.org/changeset/133585>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.