SSIA
Created attachment 172055 [details] Patch
Comment on attachment 172055 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172055&action=review LGTM > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h:196 > + inline Ewk_View_Smart_Data* smartData() const; well, I don't like this. However it's common problem in EFL WK2 and probably should be fixed in all the places
Comment on attachment 172055 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172055&action=review > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h:183 > - WebKit::PageViewportControllerClientEfl* pageViewportControllerClient() { return m_pageViewportControllerClient.get(); } > - WebKit::PageViewportController* pageViewportController() { return m_pageViewportController.get(); } > + WebKit::PageViewportControllerClientEfl* pageViewportControllerClient() const { return m_pageViewportControllerClient.get(); } > + WebKit::PageViewportController* pageViewportController() const { return m_pageViewportController.get(); } This is against the new rule in webkit that const methods should return const pointers.
> This is against the new rule in webkit that const methods should return const pointers. Mikhail will go over all the const work soon, but separately from this.
Comment on attachment 172055 [details] Patch Rejecting attachment 172055 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Kit2/UIProcess/API/efl/ewk_view.cpp Hunk #2 FAILED at 168. Hunk #3 succeeded at 222 (offset -1 lines). Hunk #4 succeeded at 230 (offset -1 lines). Hunk #5 succeeded at 243 (offset -1 lines). Hunk #6 succeeded at 864 (offset -1 lines). 1 out of 6 hunks FAILED -- saving rejects to file Source/WebKit2/UIProcess/API/efl/ewk_view.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Simon Haus..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/14678906
Landed in 133423